Oilpan: move ServiceWorkerGlobalScopeProxy to the heap.

third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 44 matching lines @@
 //
 // This implements WebServiceWorkerContextProxy, which connects ServiceWorker's
 // WorkerGlobalScope and embedder/chrome, and implements ServiceWorker-specific
 // events/upcall methods that are to be called by embedder/chromium,
 // e.g. onfetch.
 //
 // An instance of this class is supposed to outlive until
 // workerThreadTerminated() is called by its corresponding
 // WorkerGlobalScope.
 class ServiceWorkerGlobalScopeProxy final
-    : public WebServiceWorkerContextProxy
+    : public NoBaseWillBeGarbageCollectedFinalized<ServiceWorkerGlobalScopeProxy>
+    , public WebServiceWorkerContextProxy
     , public WorkerReportingProxy {
     WTF_MAKE_NONCOPYABLE(ServiceWorkerGlobalScopeProxy);
-    USING_FAST_MALLOC(ServiceWorkerGlobalScopeProxy);
+    USING_FAST_MALLOC_WILL_BE_REMOVED(ServiceWorkerGlobalScopeProxy);
 public:
-    static PassOwnPtr<ServiceWorkerGlobalScopeProxy> create(WebEmbeddedWorkerImpl&, Document&, WebServiceWorkerContextClient&);
+    static PassOwnPtrWillBeRawPtr<ServiceWorkerGlobalScopeProxy> create(WebEmbeddedWorkerImpl&, Document&, WebServiceWorkerContextClient&);
     ~ServiceWorkerGlobalScopeProxy() override;
 
     // WebServiceWorkerContextProxy overrides:
     void setRegistration(WebPassOwnPtr<WebServiceWorkerRegistration::Handle>) override;
     void dispatchActivateEvent(int) override;
     void dispatchCrossOriginMessageEvent(const WebCrossOriginServiceWorkerClient&, const WebString& message, const WebMessagePortChannelArray&) override;
     void dispatchFetchEvent(int, const WebServiceWorkerRequest&) override;
     void dispatchGeofencingEvent(int, WebGeofencingEventType, const WebString& regionID, const WebCircularGeofencingRegion&) override;
     void dispatchInstallEvent(int) override;
     void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray&) override;
     void dispatchNotificationClickEvent(int, int64_t notificationID, const WebNotificationData&, int actionIndex) override;
     void dispatchPushEvent(int, const WebString& data) override;
     void dispatchServicePortConnectEvent(WebServicePortConnectEventCallbacks*, const WebURL& targetURL, const WebString& origin, WebServicePortID) override;
     void dispatchSyncEvent(int, const WebSyncRegistration&, LastChanceOption) override;
 
     // WorkerReportingProxy overrides:
     void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) override;
     void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;
     void postMessageToPageInspector(const String&) override;
     void postWorkerConsoleAgentEnabled() override { }
     void didEvaluateWorkerScript(bool success) override;
     void didInitializeWorkerContext() override;
     void workerGlobalScopeStarted(WorkerGlobalScope*) override;
     void workerGlobalScopeClosed() override;
     void willDestroyWorkerGlobalScope() override;
     void workerThreadTerminated() override;
 
+    DECLARE_TRACE();
+
 private:
     ServiceWorkerGlobalScopeProxy(WebEmbeddedWorkerImpl&, Document&, WebServiceWorkerContextClient&);
 
     WebEmbeddedWorkerImpl& m_embeddedWorker;

[haraken, 2015/11/17 13:04:36]

WebEmbeddedWorkerImpl is still off the heap. Doesn't the m_embeddedWorker have a
risk of becoming a stale pointer? (in a period from when the
WebEmbeddedWorkerImpl gets destructed to when the next GC is triggered)

[sof, 2015/11/17 13:43:04]

This object would have to be used by a worker thread that we terminate before
finalizing WebEmbeddedWorkerImpl, so it is not likely?

That said, we could dispose/detach this proxy as part of finalizing
WebEmbedddWorkerImpl.

-    Document& m_document;
+    RawPtrWillBeMember<Document> m_document;
     KURL m_documentURL;
 
     WebServiceWorkerContextClient& m_client;

[haraken, 2015/11/17 13:04:36]

Similarly, is this raw pointer safe?

 
-    ServiceWorkerGlobalScope* m_workerGlobalScope;
+    RawPtrWillBeMember<ServiceWorkerGlobalScope> m_workerGlobalScope;
 };
 
 } // namespace blink
 
 #endif // ServiceWorkerGlobalScopeProxy_h