Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1448343002: [turbofan] Finish support for holey double elements backing stores. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Finish support for holey double elements backing stores. Also properly support loading from holey double element backing stores in JSNativeContextSpecialization. This adds a new simplified operator NumberIsHoleNaN, which checks whether a certain value is the special NaN that we use to encode "the hole" in holey double element backing stores. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/5716426b26e933b85b6bf0fd4f2fd94a8b51ce24 Cr-Commit-Position: refs/heads/master@{#32039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -6 lines) Patch
M src/compiler/access-info.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +26 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-17 12:02:59 UTC) #1
Benedikt Meurer
Hey Jaro, Finishing series of patches for native context specialization. Next is refactoring round 1 ...
5 years, 1 month ago (2015-11-17 12:04:35 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-11-17 12:34:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448343002/1
5 years, 1 month ago (2015-11-17 13:05:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 13:14:15 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 13:14:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5716426b26e933b85b6bf0fd4f2fd94a8b51ce24
Cr-Commit-Position: refs/heads/master@{#32039}

Powered by Google App Engine
This is Rietveld 408576698