Prepare to enable in-object properties in subclasses on a case by case basis.

Prepare to enable in-object properties in subclasses on a case by case basis.

Minor cleanup in VisitorId selection.

Committed: https://crrev.com/7c449a62edfc03aed84d94da323dcfe2b51a3600
Cr-Commit-Position: refs/heads/master@{#32030}

[Igor Sheludko, 2015-11-17 08:32:18]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2015-11-17 08:36:10]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2015-11-17 08:36:50]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 08:36:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1448313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1448313002/40001

[commit-bot: I haz the power, 2015-11-17 08:37:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 08:37:51]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/10807)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/11905)

[Igor Sheludko, 2015-11-17 08:44:11]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2015-11-17 08:45:05]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 08:45:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1448313002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1448313002/60001

[Igor Sheludko, 2015-11-17 08:45:29]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2015-11-17 08:45:29]

PTAL

[Igor Sheludko, 2015-11-17 08:46:28]

Description was changed from

==========
Prepare to enable in-object properties in subclasses in a case by case basis.

Minor cleanup in VisitorId selection.
==========

to

==========
Prepare to enable in-object properties in subclasses on a case by case basis.

Minor cleanup in VisitorId selection.
==========

[Toon Verwaest, 2015-11-17 08:55:35]

lgtm

[Igor Sheludko, 2015-11-17 08:56:02]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Igor Sheludko, 2015-11-17 08:56:03]

Michi, PTAL heap part.

[Michael Starzinger, 2015-11-17 09:35:40]

https://codereview.chromium.org/1448313002/diff/80001/src/heap/objects-visiti...
File src/heap/objects-visiting.cc (right):

https://codereview.chromium.org/1448313002/diff/80001/src/heap/objects-visiti...
src/heap/objects-visiting.cc:152: // Fall through.
IMHO this fall-through case just makes the code unnecessary hard to read and
refactor. I think it is fine to have a separate call to GetVisitorIdForSize()
for this block of instance types and move the block back up to the other
JS_FOO_TYPE objects.

[Igor Sheludko, 2015-11-17 09:54:03]

Addressed comments.

https://codereview.chromium.org/1448313002/diff/80001/src/heap/objects-visiti...
File src/heap/objects-visiting.cc (right):

https://codereview.chromium.org/1448313002/diff/80001/src/heap/objects-visiti...
src/heap/objects-visiting.cc:152: // Fall through.
On 2015/11/17 09:35:40, Michael Starzinger wrote:
> IMHO this fall-through case just makes the code unnecessary hard to read and
> refactor. I think it is fine to have a separate call to GetVisitorIdForSize()
> for this block of instance types and move the block back up to the other
> JS_FOO_TYPE objects.

Done.

[Michael Starzinger, 2015-11-17 10:26:52]

LGTM on "heap".

[Michael Starzinger, 2015-11-17 10:27:22]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-11-17 10:27:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1448313002/#ps100001
(title: "Addressing comments")

[commit-bot: I haz the power, 2015-11-17 10:27:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1448313002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1448313002/100001

[commit-bot: I haz the power, 2015-11-17 11:15:49]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-11-17 11:16:35]

Patchset 3 (id:??) landed as
https://crrev.com/7c449a62edfc03aed84d94da323dcfe2b51a3600
Cr-Commit-Position: refs/heads/master@{#32030}

[Benedikt Meurer, 2015-11-17 13:17:07]

A revert of this CL (patchset #3 id:100001) has been created in
https://codereview.chromium.org/1449423002/ by bmeurer@chromium.org.

The reason for reverting is: Breaks GC stress:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds....