Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1448283003: Notification custom layouts: remove any possible old buttons. (Closed)

Created:
5 years, 1 month ago by Michael van Ouwerkerk
Modified:
5 years, 1 month ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@CustomLayoutsIconColor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notification custom layouts: remove any possible old buttons. BUG=554521 Committed: https://crrev.com/c583c6aff3d262abc7846f02d61104efca9805a0 Cr-Commit-Position: refs/heads/master@{#360624}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and amend comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
5 years, 1 month ago (2015-11-17 10:43:05 UTC) #2
Peter Beverloo
lgtm https://codereview.chromium.org/1448283003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java (right): https://codereview.chromium.org/1448283003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java#newcode233 chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java:233: // We might be updating an existing notification, ...
5 years, 1 month ago (2015-11-17 10:46:50 UTC) #3
Michael van Ouwerkerk
https://codereview.chromium.org/1448283003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java (right): https://codereview.chromium.org/1448283003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java#newcode233 chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java:233: // We might be updating an existing notification, so ...
5 years, 1 month ago (2015-11-19 17:23:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448283003/20001
5 years, 1 month ago (2015-11-19 17:24:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 18:03:17 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 18:04:26 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c583c6aff3d262abc7846f02d61104efca9805a0
Cr-Commit-Position: refs/heads/master@{#360624}

Powered by Google App Engine
This is Rietveld 408576698