Issue 1448243002: Specialize Glob for the often case of suffix matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1448243002: Specialize Glob for the often case of suffix matching. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Specialize Glob for the often case of suffix matching. This makes it about 2.5 times faster in the micro-benchmark. No noticable difference for DAS. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/96b494665e0aeb6e3b7ed37bf3db52d4c50cbfc9

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -8 lines)			Patch
	M	pkg/analyzer/lib/src/util/glob.dart	View		3 chunks	+35 lines, -8 lines	1 comment	Download
	M	pkg/analyzer/test/src/util/glob_test.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1448243002/diff/1/pkg/analyzer/lib/src/util/glob.dart File pkg/analyzer/lib/src/util/glob.dart (right): https://codereview.chromium.org/1448243002/diff/1/pkg/analyzer/lib/src/util/glob.dart#newcode41 pkg/analyzer/lib/src/util/glob.dart:41: _suffix = _pattern.substring(4); Probably ought to use toLowerCase() ...

5 years, 1 month ago (2015-11-17 14:54:08 UTC) #2

scheglov

5 years, 1 month ago (2015-11-17 18:23:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
96b494665e0aeb6e3b7ed37bf3db52d4c50cbfc9 (presubmit successful).

Expand Messages | Collapse Messages