build/android/emma_instr_action.gypi - Issue 1448223004: Refactor emma_instr.py in preparation for porting EMMA GYP rules to GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/emma_instr_action.gypi

Issue 1448223004: Refactor emma_instr.py in preparation for porting EMMA GYP rules to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/emma_instr_action.gypi

diff --git a/build/android/emma_instr_action.gypi b/build/android/emma_instr_action.gypi

index 5d22c2671c13e3649407f33200aeaac251e2f082..0505eab21a680864dec51b46cc1597aafe2cb18a 100644

--- a/build/android/emma_instr_action.gypi

+++ b/build/android/emma_instr_action.gypi

@@ -11,14 +11,14 @@

'output_path%': '',

'stamp_path%': '',

'extra_instr_args': [

- '--coverage-file=<(_target_name).em',

- '--sources-file=<(_target_name)_sources.txt',

+ '--coverage-file=<(coverage_file)',

+ '--sources-list-file=<(sources_list_file)',

'emma_jar': '<(android_sdk_root)/tools/lib/emma.jar',

'conditions': [

['emma_instrument != 0', {

'extra_instr_args': [

- '--sources=<(java_in_dir)/src >(additional_src_dirs) >(generated_src_dirs)',

+ '--source-dirs=<(java_in_dir)/src >(additional_src_dirs) >(generated_src_dirs)',

'--src-root=<(DEPTH)',

'--emma-jar=<(emma_jar)',

'--filter-string=<(emma_filter)',

« no previous file with comments | « no previous file | build/android/gyp/emma_instr.py » ('j') | build/android/gyp/emma_instr.py » ('J')