Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1448183002: [tests] Fix webkit class syntax tests to handle destructuring binding (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tests] Fix webkit class syntax tests to handle destructuring binding R=littledan@chromium.org Committed: https://crrev.com/47920a472f8c350192b1a0d4c4a784532c78873f Cr-Commit-Position: refs/heads/master@{#32156}

Patch Set 1 #

Patch Set 2 : Rebased, renamed flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M test/webkit/class-syntax-declaration.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/class-syntax-declaration-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/class-syntax-expression.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/class-syntax-expression-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
adamk
5 years, 1 month ago (2015-11-17 00:01:59 UTC) #1
adamk
ping?
5 years, 1 month ago (2015-11-20 23:39:13 UTC) #2
Dan Ehrenberg
lgtm Yay
5 years, 1 month ago (2015-11-20 23:59:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448183002/20001
5 years, 1 month ago (2015-11-20 23:59:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-21 00:23:31 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 00:24:11 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47920a472f8c350192b1a0d4c4a784532c78873f
Cr-Commit-Position: refs/heads/master@{#32156}

Powered by Google App Engine
This is Rietveld 408576698