Issue 1448173002: Add ApplyChangesStatus to AnalysisContext.applyChanges() and use it in DAS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1448173002: Add ApplyChangesStatus to AnalysisContext.applyChanges() and use it in DAS. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add ApplyChangesStatus to AnalysisContext.applyChanges() and use it in DAS. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/de6925a23ebf29cd587dd5f4e214cb277a7397e4

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -22 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/analysis_server_test.dart	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/context/context.dart	View	3 chunks	+16 lines, -12 lines	1 comment	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	4 chunks	+16 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/context/context_test.dart	View	3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1448173002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1448173002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode548 pkg/analyzer/lib/src/context/context.dart:548: for (Source source in changedSources) { I don't ...

5 years, 1 month ago (2015-11-16 23:19:32 UTC) #2

scheglov

5 years, 1 month ago (2015-11-17 03:42:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
de6925a23ebf29cd587dd5f4e214cb277a7397e4 (presubmit successful).

Expand Messages | Collapse Messages