Chromium Code Reviews
DescriptionNew Mojom Compiler: Do not prepend parent kind name to enum name.
R=azani@chromium.org, azani
BUG=#461
I think we fixed this earlier and there was a regression. The generated C++ looks like:
class HandleType {
public:
enum class HandleType.Kind : int32_t {
UNSPECIFIED,
MESSAGE_PIPE,
DATA_PIPE_CONSUMER,
DATA_PIPE_PRODUCER,
SHARED_BUFFER,
};
}
Notice the declared name of the enum class is "HandleType.Kind". It should be just "Kind".
Committed: https://chromium.googlesource.com/external/mojo/+/7a5122469f6a137d7d46d655ead204df8b148e13
Patch Set 1 #Patch Set 2 : Fix mojom_translator_unittest.py. #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||