Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1448123002: New Mojom Compiler: Do not prepend parent kind name to enum name. (Closed)

Created:
5 years, 1 month ago by rudominer
Modified:
5 years, 1 month ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

New Mojom Compiler: Do not prepend parent kind name to enum name. R=azani@chromium.org, azani BUG=#461 I think we fixed this earlier and there was a regression. The generated C++ looks like: class HandleType { public: enum class HandleType.Kind : int32_t { UNSPECIFIED, MESSAGE_PIPE, DATA_PIPE_CONSUMER, DATA_PIPE_PRODUCER, SHARED_BUFFER, }; } Notice the declared name of the enum class is "HandleType.Kind". It should be just "Kind". Committed: https://chromium.googlesource.com/external/mojo/+/7a5122469f6a137d7d46d655ead204df8b148e13

Patch Set 1 #

Patch Set 2 : Fix mojom_translator_unittest.py. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rudominer
ptal
5 years, 1 month ago (2015-11-16 21:33:52 UTC) #4
rudominer
sorry, test is fixed now. ptal.
5 years, 1 month ago (2015-11-16 21:52:46 UTC) #5
azani
lgtm
5 years, 1 month ago (2015-11-16 21:53:18 UTC) #6
rudominer
5 years, 1 month ago (2015-11-16 21:53:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7a5122469f6a137d7d46d655ead204df8b148e13 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698