Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1448063002: PPC: [builtins] One runtime fallback is enough for the String constructor. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [builtins] One runtime fallback is enough for the String constructor. Port 34b7b21d1d7bf2e9c77ae5726f868e69f3b4a4f3 Original commit message: If inline allocation fails, we can just use the %NewObject fallback, which will do the right thing. We don't need a dedicated fallback to %AllocateInNewSpace. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/ff4c3f31a0cbf450d33b551b21b9ba295feab815 Cr-Commit-Position: refs/heads/master@{#32015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M src/ppc/builtins-ppc.cc View 3 chunks +17 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-16 15:28:31 UTC) #1
JoranSiu
lgtm
5 years, 1 month ago (2015-11-16 15:59:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448063002/1
5 years, 1 month ago (2015-11-16 16:11:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 16:53:43 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 16:54:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff4c3f31a0cbf450d33b551b21b9ba295feab815
Cr-Commit-Position: refs/heads/master@{#32015}

Powered by Google App Engine
This is Rietveld 408576698