Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: components/plugins/renderer/plugin_placeholder.cc

Issue 144803003: Fix issue that IME can't be enabled when set Plugin mode to "Click to play". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update the fixing with a focused_ flag in WebViewPlugin Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/plugins/renderer/plugin_placeholder.cc
diff --git a/components/plugins/renderer/plugin_placeholder.cc b/components/plugins/renderer/plugin_placeholder.cc
index deb64d7c02f37b5de34caee240cd92ea433925b7..5e092cd7e3fc40ae928985674bff0cfe441d0fc8 100644
--- a/components/plugins/renderer/plugin_placeholder.cc
+++ b/components/plugins/renderer/plugin_placeholder.cc
@@ -84,6 +84,11 @@ void PluginPlaceholder::ReplacePlugin(WebPlugin* new_plugin) {
return;
}
+ // We need to transfer the |focused_| to new plugin after it loaded.
Bernhard Bauer 2014/01/25 14:36:37 Move this down. After ReplayReceivedData() seems t
Ruiyi Luo 2014/01/26 09:40:28 Agree with you. Merging it with ReplayReceivedDat
+ if (plugin_->hasFocus()) {
+ new_plugin->updateFocus(true);
+ }
+
// The plug-in has been removed from the page. Destroy the old plug-in. We
// will be destroyed as soon as V8 garbage collects us.
if (!element.pluginContainer()) {

Powered by Google App Engine
This is Rietveld 408576698