Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1447973002: Enable temporarily disabled GpuDrawPathTest (Closed)

Created:
5 years, 1 month ago by Kimmo Kinnunen
Modified:
5 years, 1 month ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable temporarily disabled GpuDrawPathTest Enable temporarily disabled GpuDrawPathTest. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d6346290c2ef59abee453a72f3e91b4e7b62f4fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tests/GpuDrawPathTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Kimmo Kinnunen
5 years, 1 month ago (2015-11-16 08:45:58 UTC) #2
jvanverth1
lgtm Why was it disabled in the first place?
5 years, 1 month ago (2015-11-16 14:27:00 UTC) #3
Kimmo Kinnunen
On 2015/11/16 14:27:00, jvanverth1 wrote: > lgtm > > Why was it disabled in the ...
5 years, 1 month ago (2015-11-16 17:41:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447973002/1
5 years, 1 month ago (2015-11-16 17:41:47 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 17:54:13 UTC) #8
Kimmo Kinnunen
On 2015/11/16 17:41:04, Kimmo Kinnunen wrote: > On 2015/11/16 14:27:00, jvanverth1 wrote: > > lgtm ...
5 years, 1 month ago (2015-11-16 18:09:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447973002/1
5 years, 1 month ago (2015-11-17 06:11:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d6346290c2ef59abee453a72f3e91b4e7b62f4fa
5 years, 1 month ago (2015-11-17 06:12:43 UTC) #12
caryclark
5 years, 1 month ago (2015-11-17 12:28:05 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1456463003/ by caryclark@google.com.

The reason for reverting is: broke windows builds.

Powered by Google App Engine
This is Rietveld 408576698