Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1447943002: Revert of Add unit tests for CdmAdapter (Closed)

Created:
5 years, 1 month ago by zhaoqin1
Modified:
5 years, 1 month ago
Reviewers:
jrummell, xhwang
CC:
chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add unit tests for CdmAdapter (patchset #6 id:100001 of https://codereview.chromium.org/1428753010/ ) Reason for revert: valgrind reports leaks with no-debug-symbol callstack BUG=556346 TBR=jrummell@chromium.org Original issue's description: > Add unit tests for CdmAdapter > > BUG=510088 > TEST=new unittests pass > > Committed: https://crrev.com/30996193fe3e69fe9ccd52471900bf5685c54956 > Cr-Commit-Position: refs/heads/master@{#359582} TBR=xhwang@chromium.org,jrummell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510088 Committed: https://crrev.com/0d6792ab1bb79274f0945556c46e2fc4f1611e54 Cr-Commit-Position: refs/heads/master@{#359798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -396 lines) Patch
M media/BUILD.gn View 2 chunks +1 line, -7 lines 0 comments Download
M media/cdm/aes_decryptor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D media/cdm/cdm_adapter_unittest.cc View 1 chunk +0 lines, -374 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zhaoqin1
Created Revert of Add unit tests for CdmAdapter
5 years, 1 month ago (2015-11-16 03:45:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447943002/1
5 years, 1 month ago (2015-11-16 03:45:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 03:45:46 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 03:46:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d6792ab1bb79274f0945556c46e2fc4f1611e54
Cr-Commit-Position: refs/heads/master@{#359798}

Powered by Google App Engine
This is Rietveld 408576698