Implement an indeterminate progress-bar

ui/message_center/views/notification_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_MESSAGE_CENTER_VIEWS_NOTIFICATION_VIEW_H_
 #define UI_MESSAGE_CENTER_VIEWS_NOTIFICATION_VIEW_H_
 
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "ui/message_center/message_center_export.h"
 #include "ui/message_center/views/message_view.h"
 #include "ui/views/view_targeter_delegate.h"
 
 class GURL;
 
 namespace views {
 class ProgressBar;
 }
 
 namespace message_center {
 
 class BoundedLabel;
 class MessageCenter;
 class MessageCenterController;
 class NotificationButton;
+class NotificationProgressBar;
+class NotificationIndeterminateProgressBar;
 class NotificationView;
 class PaddedButton;
 class ProportionalImageView;
 
 // View that displays all current types of notification (web, basic, image, and
 // list). Future notification types may be handled by other classes, in which
 // case instances of those classes would be returned by the Create() factory
 // method below.
 class MESSAGE_CENTER_EXPORT NotificationView
     : public MessageView,
@@ skipping 55 matching lines @@
   views::View* TargetForRect(views::View* root, const gfx::Rect& rect) override;
 
   void CreateOrUpdateViews(const Notification& notification);
   void SetAccessibleName(const Notification& notification);
 
   void CreateOrUpdateTitleView(const Notification& notification);
   void CreateOrUpdateMessageView(const Notification& notification);
   void CreateOrUpdateContextMessageView(const Notification& notification);
   void CreateOrUpdateSettingsButtonView(const Notification& notification);
   void CreateOrUpdateProgressBarView(const Notification& notification);
+  void CreateOrUpdateIndeterminateProgressBarView(
+      const Notification& notification);
   void CreateOrUpdateListItemViews(const Notification& notification);
   void CreateOrUpdateIconView(const Notification& notification);
   void CreateOrUpdateImageView(const Notification& notification);
   void CreateOrUpdateActionButtonViews(const Notification& notification);
 
   int GetMessageLineLimit(int title_lines, int width) const;
   int GetMessageHeight(int width, int limit) const;
 
   // Formats the context message to be displayed based on |context|
   // so it shows as much information as possible
@@ skipping 10 matching lines @@
   views::View* top_view_;
   BoundedLabel* title_view_;
   BoundedLabel* message_view_;
   BoundedLabel* context_message_view_;
   views::ImageButton* settings_button_view_;
   std::vector<views::View*> item_views_;
   ProportionalImageView* icon_view_;
   views::View* bottom_view_;
   views::View* image_container_;
   ProportionalImageView* image_view_;
-  views::ProgressBar* progress_bar_view_;
+  NotificationProgressBar* progress_bar_view_;
+  NotificationIndeterminateProgressBar* indeterminate_progress_bar_view_;

[Jun Mukai, 2015/11/24 17:51:12]

I don't think we should have two different instance variables, they would share
the same interface, and they are placed in the same position. I proposed to
split class because they make different visual effects.

So, NotificationView will recreate the view instance and swap
|progress_bar_view_| upon intermediate flag.

[yoshiki, 2015/11/25 15:14:28]

Done.

   std::vector<NotificationButton*> action_buttons_;
   std::vector<views::View*> separators_;
 
   DISALLOW_COPY_AND_ASSIGN(NotificationView);
 };
 
 }  // namespace message_center
 
 #endif  // UI_MESSAGE_CENTER_VIEWS_NOTIFICATION_VIEW_H_