chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc - Issue 144783002: Simplify directory initialization in Files app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

Issue 144783002: Simplify directory initialization in Files app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleaned up. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/select_file_dialog_extension.cc ('k') | chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

diff --git a/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc b/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

index f48d7cd83fac9da3e711ae1e9922c919a33d16d8..86899fb4333aff9b4e88967707ecfecbf8568ce5 100644

--- a/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

+++ b/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

@@ -9,6 +9,7 @@

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

#include "base/path_service.h"

+#include "base/prefs/pref_service.h"

#include "base/strings/utf_string_conversions.h"

#include "base/threading/platform_thread.h"

#include "build/build_config.h"

@@ -21,6 +22,7 @@

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/common/chrome_paths.h"

+#include "chrome/common/pref_names.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_types.h"

#include "content/public/browser/render_view_host.h"

@@ -115,6 +117,8 @@ class SelectFileDialogExtensionBrowserTest : public ExtensionBrowserTest {

void AddMountPoint(const base::FilePath& path) {

EXPECT_TRUE(file_manager::util::RegisterDownloadsMountPoint(

browser()->profile(), path));

+ browser()->profile()->GetPrefs()->SetFilePath(

+ prefs::kDownloadDefaultDirectory, downloads_dir_);

}

void CheckJavascriptErrors() {