Issue 1447823003: Revert of Implemented clearing Java prefs after pulling variations first run seed from Java to C++ side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1447823003: Revert of Implemented clearing Java prefs after pulling variations first run seed from Java to C++ side (Closed)

Created:
5 years, 1 month ago by loyso (OOO)

Modified:
5 years, 1 month ago

Reviewers:
Alexei Svitkine (slow), Steven Holte, Alexander Agulenko

CC:
chromium-reviews, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Implemented clearing Java prefs after pulling variations first run seed from Java to C++ side (patchset #8 id:140001 of https://codereview.chromium.org/1437833004/ ) Reason for revert: Crashes android gn build (component unittests) Original issue's description: > Implemented clearing Java prefs after pulling variations first run seed from Java to C++ side > > BUG=551029 > > Committed: https://crrev.com/683e65ca552aad24fd7794ca362a198103519d7f > Cr-Commit-Position: refs/heads/master@{#359649} TBR=asvitkine@chromium.org,holte@chromium.org,agulenko@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=551029 Committed: https://crrev.com/7864dbb36351f600794158ef1b0bfeaf604382b4 Cr-Commit-Position: refs/heads/master@{#359726}

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -101 lines)			Patch
M	components/components_tests.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/variations/BUILD.gn	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedBridge.java	View	3 chunks	+5 lines, -43 lines	0 comments	Download
M	components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedService.java	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	components/variations/android/variations_seed_bridge.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	components/variations/android/variations_seed_bridge.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	components/variations/variations_seed_store.cc	View	3 chunks	+1 line, -14 lines	0 comments	Download

Total messages: 1 (0 generated)

loyso (OOO)

5 years, 1 month ago (2015-11-14 01:31:56 UTC) #1

Created Revert of Implemented clearing Java prefs after pulling variations first
run seed from Java to C++ side