Bulk Reports: Fix an infinite loop in ChildTraceMessageFilter::OnSetUMACallback.

Bulk Reports: Fix an infinite loop in ChildTraceMessageFilter::OnSetUMACallback.

Also added some unit testing for this file.

BUG=555690
Committed: https://crrev.com/5ee44554d36595c779c59adef061dce09fe6d2a6
Cr-Commit-Position: refs/heads/master@{#359736}

[shatch, 2015-11-13 21:25:44]

Patchset #1 (id:1) has been deleted

[shatch, 2015-11-13 23:15:02]

Description was changed from

==========
.


.


.


.


.

BUG=
==========

to

==========
Bulk Reports: Fix an infinite loop in ChildTraceMessageFilter::OnSetUMACallback.

Also added some unit testing for this file.

BUG=555690
==========

[shatch, 2015-11-13 23:15:02]

simonhatch@chromium.org changed reviewers:
+ oysteine@chromium.org

[shatch, 2015-11-13 23:17:04]

Patchset #2 (id:40001) has been deleted

[oystein (OOO til 10th of July), 2015-11-13 23:23:49]

lgtm

[oystein (OOO til 10th of July), 2015-11-13 23:25:27]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2015-11-13 23:27:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1447643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1447643002/60001

[commit-bot: I haz the power, 2015-11-14 00:16:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-14 00:16:01]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[oystein (OOO til 10th of July), 2015-11-14 02:00:36]

The CQ bit was checked by oysteine@chromium.org

[oystein (OOO til 10th of July), 2015-11-14 02:00:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
oysteine@chromium.org
Link to the patchset: https://codereview.chromium.org/1447643002/#ps80001
(title: "Fix IOS.")

[commit-bot: I haz the power, 2015-11-14 02:03:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1447643002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1447643002/80001

[commit-bot: I haz the power, 2015-11-14 02:10:48]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-11-14 02:11:49]

Patchset 3 (id:??) landed as
https://crrev.com/5ee44554d36595c779c59adef061dce09fe6d2a6
Cr-Commit-Position: refs/heads/master@{#359736}

[Nico, 2016-05-18 13:03:51]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-05-18 13:03:52]

(fyi, you forgot to add the new test to components/tracing/BUILD.gn:unit_tests.
I'm fixing this, this is just to encourage you to not forget gn files the next
time you add a test :-) )

[Will Harris, 2016-05-18 13:05:44]

On 2016/05/18 13:03:52, Nico (vacation May 19 to 22) wrote:
> (fyi, you forgot to add the new test to
components/tracing/BUILD.gn:unit_tests.
> I'm fixing this, this is just to encourage you to not forget gn files the next
> time you add a test :-) )

maybe we need tests to test that the tests tested in the unit_tests in gn vs gyp
are the same :)

[shatch, 2016-05-18 13:19:21]

On 2016/05/18 13:05:44, Will Harris (slow thru 23 May) wrote:
> On 2016/05/18 13:03:52, Nico (vacation May 19 to 22) wrote:
> > (fyi, you forgot to add the new test to
> components/tracing/BUILD.gn:unit_tests.
> > I'm fixing this, this is just to encourage you to not forget gn files the
next
> > time you add a test :-) )
> 
> maybe we need tests to test that the tests tested in the unit_tests in gn vs
gyp
> are the same :)

But will those tests be tested? :p

re thakis: Thanks!