Issue 1447603004: Fix for the watcher leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1447603004: Fix for the watcher leak. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for the watcher leak. We need not just to cancel the subscription, but also to remove it from the map. It's not so bad now for the MDL project, but any similar project will use a lot of memory even after closign the project. This may be the reason of one of the issues opened against DAS. R=brianwilkerson@google.com, paulberry@google.com BUG= https://github.com/dart-lang/sdk/issues/24613 Committed: https://github.com/dart-lang/sdk/commit/610401a8d5dce8a59be3eefb3422d30b26f53b86

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	pkg/analysis_server/lib/src/context_manager.dart	View		3 chunks	+3 lines, -5 lines	0 comments	Download
	M	pkg/analysis_server/test/context_manager_test.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

scheglov

5 years, 1 month ago (2015-11-14 02:24:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
610401a8d5dce8a59be3eefb3422d30b26f53b86 (presubmit successful).