Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: build/android/gyp/process_resources.py

Issue 14476011: [Android] Auto-generate API 14 resources from the existing API 17 resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed Newton's comments and polished. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/gyp/process_resources.py
diff --git a/build/android/gyp/process_resources.py b/build/android/gyp/process_resources.py
index 40f1017ce5cf92df9a7d8164812d17b5556e4230..6e9e84c37c7cc1d1bf257a70d2a5f3a6ffe5318b 100755
--- a/build/android/gyp/process_resources.py
+++ b/build/android/gyp/process_resources.py
@@ -29,6 +29,10 @@ def ParseArgs():
help='directory containing images to be crunched')
parser.add_option('--crunch-output-dir',
help='directory to hold crunched resources')
+ parser.add_option('--res-mirror-input-dir',
+ help='directory containing LTR resources to be mirrored')
+ parser.add_option('--res-mirror-output-dir',
+ help='directory to hold mirrored, RTL resources')
parser.add_option('--non-constant-id', action='store_true')
parser.add_option('--custom-package', help='Java package for R.java')
parser.add_option('--android-manifest', help='AndroidManifest.xml path')
@@ -44,7 +48,8 @@ def ParseArgs():
# Check that required options have been provided.
required_options = ('android_sdk', 'android_sdk_tools', 'R_dir', 'res_dirs',
- 'crunch_input_dir', 'crunch_output_dir')
+ 'crunch_input_dir', 'crunch_output_dir',
+ 'res_mirror_input_dir', 'res_mirror_output_dir')
build_utils.CheckOptions(options, parser, required=required_options)
return options
@@ -89,6 +94,14 @@ def main():
'-C', options.crunch_output_dir]
build_utils.CheckCallDie(aapt_cmd, suppress_output=True)
+ # Generate RTL versions of layouts and other XML resources.
+ build_utils.MakeDirectory(options.res_mirror_output_dir)
+ mirror_cmd = ['mirror_resources.py',
+ '--res-dir', options.res_mirror_input_dir,
+ '--res-mirrored-dir', options.res_mirror_output_dir]
+ build_utils.CheckCallDie(mirror_cmd, suppress_output=True)
+
+
if options.stamp:
build_utils.Touch(options.stamp)

Powered by Google App Engine
This is Rietveld 408576698