[Android] Auto-generate API 14 resources from the existing API 17 resources.

build/android/gyp/process_resources.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Process Android library resources to generate R.java and crunched images."""
 
 import optparse
 import os
 import shlex
+import sys
 
 from util import build_utils
 
 def ParseArgs():
   """Parses command line options.
 
   Returns:
     An options object as from optparse.OptionsParser.parse_args()
   """
   parser = optparse.OptionParser()
   parser.add_option('--android-sdk', help='path to the Android SDK folder')
   parser.add_option('--android-sdk-tools',
                     help='path to the Android SDK platform tools folder')
   parser.add_option('--R-dir', help='directory to hold generated R.java')
   parser.add_option('--res-dirs',
                     help='directories containing resources to be packaged')
-  parser.add_option('--crunch-input-dir',
-                    help='directory containing images to be crunched')
+  parser.add_option('--crunch-and-mirror-input-dir',
+                    help='directory containing images to be crunched and' \

[newt (away), 2013/04/25 00:47:58]

don't need \

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Line_l...

[Kibeom Kim (inactive), 2013/04/25 01:49:35]

Done.

+                         'LTR resources to be mirrored')
   parser.add_option('--crunch-output-dir',
                     help='directory to hold crunched resources')
+  parser.add_option('--mirror-output-dir',
+                    help='directory to hold mirrored, RTL resources')
   parser.add_option('--non-constant-id', action='store_true')
   parser.add_option('--custom-package', help='Java package for R.java')
   parser.add_option('--android-manifest', help='AndroidManifest.xml path')
   parser.add_option('--stamp', help='File to touch on success')
 
   # This is part of a temporary fix for crbug.com/177552.
   # TODO(newt): remove this once crbug.com/177552 is fixed in ninja.
   parser.add_option('--ignore', help='this argument is ignored')
   (options, args) = parser.parse_args()
 
   if args:
     parser.error('No positional arguments should be given.')
 
   # Check that required options have been provided.
   required_options = ('android_sdk', 'android_sdk_tools', 'R_dir', 'res_dirs',
-                      'crunch_input_dir', 'crunch_output_dir')
+                      'crunch_and_mirror_input_dir', 'crunch_output_dir',
+                      'mirror_output_dir')
   build_utils.CheckOptions(options, parser, required=required_options)
 
   return options
 
 
 def main():
   options = ParseArgs()
   android_jar = os.path.join(options.android_sdk, 'android.jar')
   aapt = os.path.join(options.android_sdk_tools, 'aapt')
 
@@ skipping 20 matching lines @@
   if options.custom_package:
     package_command += ['--custom-package', options.custom_package]
   build_utils.CheckCallDie(package_command)
 
   # Crunch image resources. This shrinks png files and is necessary for 9-patch
   # images to display correctly.
   build_utils.MakeDirectory(options.crunch_output_dir)
 
   aapt_cmd = [aapt,
               'crunch',
-              '-S', options.crunch_input_dir,
+              '-S', options.crunch_and_mirror_input_dir,
               '-C', options.crunch_output_dir]
   build_utils.CheckCallDie(aapt_cmd, suppress_output=True)
 
+  # Generate RTL versions of layouts and other XML resources.
+  build_utils.MakeDirectory(options.mirror_output_dir)
+  mirror_cmd = [sys.executable,

[newt (away), 2013/04/25 00:47:58]

Chris may know the best way to do this

[cjhopman, 2013/04/25 01:02:06]

Haven't looked at the rest of the change yet, but for this:

Much better than calling this in a subprocess would be to import
mirror_resources and call things directly.

I think I would prefer that this be done as a separate gyp action, though. Feel
free to ping me for details of what that would take.

[Kibeom Kim (inactive), 2013/04/25 01:49:35]

OK I'll try to make this a separate gyp action after converting this script to
handle layout-v17

On 2013/04/25 01:02:06, cjhopman wrote:

+                os.path.join(os.path.dirname(__file__), 'mirror_resources.py'),
+                '--res-dir', options.crunch_and_mirror_input_dir,
+                '--res-mirrored-dir', options.mirror_output_dir]
+  build_utils.CheckCallDie(mirror_cmd, suppress_output=True)
+
+
   if options.stamp:
     build_utils.Touch(options.stamp)
 
 
 if __name__ == '__main__':
   main()