Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 14476009: Enable api tests on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_arm.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm.cc (revision 21960)
+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)
@@ -1073,7 +1073,21 @@
intptr_t deopt_id,
intptr_t token_pos,
LocationSummary* locs) {
- UNIMPLEMENTED();
+ // Each ICData propagated from unoptimized to optimized code contains the
+ // function that corresponds to the Dart function of that IC call. Due
+ // to inlining in optimized code, that function may not correspond to the
+ // top-level function (parsed_function().function()) which could be
+ // reoptimized and which counter needs to be incremented.
+ // Pass the function explicitly, it is used in IC stub.
+ __ LoadObject(R6, parsed_function().function());
+ __ LoadObject(R4, arguments_descriptor);
+ __ LoadObject(R5, ic_data);
+ GenerateDartCall(deopt_id,
+ token_pos,
+ target_label,
+ PcDescriptors::kIcCall,
+ locs);
+ __ Drop(argument_count);
}
@@ -1128,7 +1142,28 @@
void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg,
const Object& obj,
bool needs_number_check) {
- UNIMPLEMENTED();
+ if (needs_number_check) {
+ if (!obj.IsMint() && !obj.IsDouble() && !obj.IsBigint()) {
+ needs_number_check = false;
+ }
+ }
+
+ if (obj.IsSmi() && (Smi::Cast(obj).Value() == 0)) {
+ ASSERT(!needs_number_check);
+ __ tst(reg, ShifterOperand(reg));
+ return;
+ }
+
+ if (needs_number_check) {
+ __ Push(reg);
+ __ PushObject(obj);
+ __ BranchLink(&StubCode::IdenticalWithNumberCheckLabel());
+ __ Drop(1); // Discard constant.
+ __ Pop(reg); // Restore 'reg'.
+ return;
+ }
+
+ __ CompareObject(reg, obj);
}

Powered by Google App Engine
This is Rietveld 408576698