Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: components/scheduler/base/task_queue_impl.cc

Issue 1447563002: Implement frame attribution (FrameBlamer) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make sure blame context is initialized early enough Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/base/task_queue_impl.cc
diff --git a/components/scheduler/base/task_queue_impl.cc b/components/scheduler/base/task_queue_impl.cc
index 57d3686ff2b6cf73c6b8e65f8fd2c799fe88a361..7a3c08a382a5bf8d0b695c8741f9ce59f0107b4e 100644
--- a/components/scheduler/base/task_queue_impl.cc
+++ b/components/scheduler/base/task_queue_impl.cc
@@ -4,6 +4,7 @@
#include "components/scheduler/base/task_queue_impl.h"
+#include "base/trace_event/blame_context.h"
#include "components/scheduler/base/task_queue_manager.h"
#include "components/scheduler/base/task_queue_manager_delegate.h"
#include "components/scheduler/base/time_domain.h"
@@ -109,7 +110,8 @@ TaskQueueImpl::MainThreadOnly::MainThreadOnly(
delayed_work_queue(new WorkQueue(task_queue, "delayed")),
immediate_work_queue(new WorkQueue(task_queue, "immediate")),
set_index(0),
- is_enabled(true) {}
+ is_enabled(true),
+ blame_context(nullptr) {}
TaskQueueImpl::MainThreadOnly::~MainThreadOnly() {}
@@ -611,6 +613,8 @@ void TaskQueueImpl::RemoveTaskObserver(
void TaskQueueImpl::NotifyWillProcessTask(
const base::PendingTask& pending_task) {
DCHECK(should_notify_observers_);
+ if (main_thread_only().blame_context)
+ main_thread_only().blame_context->Enter();
FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver,
main_thread_only().task_observers,
WillProcessTask(pending_task));
@@ -622,6 +626,8 @@ void TaskQueueImpl::NotifyDidProcessTask(
FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver,
main_thread_only().task_observers,
DidProcessTask(pending_task));
+ if (main_thread_only().blame_context)
+ main_thread_only().blame_context->Leave();
}
void TaskQueueImpl::SetTimeDomain(TimeDomain* time_domain) {
@@ -651,6 +657,11 @@ TimeDomain* TaskQueueImpl::GetTimeDomain() const {
return any_thread().time_domain;
}
+void TaskQueueImpl::SetBlameContext(
+ base::trace_event::BlameContext* blame_context) {
+ main_thread_only().blame_context = blame_context;
+}
+
// static
void TaskQueueImpl::QueueAsValueInto(const std::queue<Task>& queue,
base::trace_event::TracedValue* state) {
« no previous file with comments | « components/scheduler/base/task_queue_impl.h ('k') | components/scheduler/base/task_queue_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698