third_party/WebKit/Source/core/loader/EmptyClients.cpp - Issue 1447563002: Implement frame attribution (FrameBlamer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/EmptyClients.cpp

Issue 1447563002: Implement frame attribution (FrameBlamer) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/EmptyClients.cpp

diff --git a/third_party/WebKit/Source/core/loader/EmptyClients.cpp b/third_party/WebKit/Source/core/loader/EmptyClients.cpp

index 592a5c7dc22e97c8576ff193760ea97bd32c0b0b..5285e82bf8d546c81e6964fca8a3a871e2f59173 100644

--- a/third_party/WebKit/Source/core/loader/EmptyClients.cpp

+++ b/third_party/WebKit/Source/core/loader/EmptyClients.cpp

@@ -73,7 +73,6 @@ public:

void setFrameVisible(bool) override { }

WebTaskRunner* loadingTaskRunner() override;

WebTaskRunner* timerTaskRunner() override;

- void setFrameOrigin(const WebSecurityOrigin&) override { }

};

WebTaskRunner* EmptyFrameScheduler::loadingTaskRunner()

@@ -114,7 +113,7 @@ String EmptyChromeClient::acceptLanguages()

return String();

}

-PassOwnPtr<WebFrameScheduler> EmptyChromeClient::createFrameScheduler()

+PassOwnPtr<WebFrameScheduler> EmptyChromeClient::createFrameScheduler(BlameContext*)

{

return adoptPtr(new EmptyFrameScheduler());

}