third_party/WebKit/Source/core/frame/Frame.h - Issue 1447563002: Implement frame attribution (FrameBlamer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 1447563002: Implement frame attribution (FrameBlamer) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: It builds => ship it. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Frame.h

diff --git a/third_party/WebKit/Source/core/frame/Frame.h b/third_party/WebKit/Source/core/frame/Frame.h

index c15b0949118f5140f6d98c86b44ff78bc84b6f27..db55ba8d0d03a74bd8d98d7f4848fa75a21694cb 100644

--- a/third_party/WebKit/Source/core/frame/Frame.h

+++ b/third_party/WebKit/Source/core/frame/Frame.h

@@ -32,6 +32,7 @@

#include "core/frame/FrameTypes.h"

#include "core/loader/FrameLoaderTypes.h"

#include "core/page/FrameTree.h"

+#include "platform/TraceEvent.h"

#include "platform/heap/Handle.h"

#include "wtf/Forward.h"

#include "wtf/RefCounted.h"

@@ -143,7 +144,7 @@ protected:

private:

RawPtrWillBeMember<FrameClient> m_client;

- // Needed to identify Frame Timing requests.

+ // Needed to identify Frame Timing requests. Also used for trace-based frame blaming.

int64_t m_frameID;

bool m_isLoading;

};