base/trace_event/trace_event_unittest.cc - Issue 1447563002: Implement frame attribution (FrameBlamer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_unittest.cc

Issue 1447563002: Implement frame attribution (FrameBlamer) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: It builds => ship it. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_event_unittest.cc

diff --git a/base/trace_event/trace_event_unittest.cc b/base/trace_event/trace_event_unittest.cc

index f3dc16dd43d9b44fa7137418d5edb71caa9f1226..582e4742fea58cfcefa583b493034be522c1aae8 100644

--- a/base/trace_event/trace_event_unittest.cc

+++ b/base/trace_event/trace_event_unittest.cc

@@ -486,7 +486,7 @@ void TraceWithAllMacroVariants(WaitableEvent* task_complete_event) {

TraceScopedTrackableObject<int> trackable("all", "tracked object 2",

0x2128506);

- trackable.snapshot("world");

+ trackable.Snapshot("world");

TRACE_EVENT_OBJECT_CREATED_WITH_ID(

"all", "tracked object 3", TRACE_ID_WITH_SCOPE("scope", 0x42));