| Index: base/test/trace_event_analyzer.cc
|
| diff --git a/base/test/trace_event_analyzer.cc b/base/test/trace_event_analyzer.cc
|
| index fc775f27b14d26dfef8c660d0e1c543c41879b1f..2ff14122432c95cf00bcbb6fadc75f3f78aa5147 100644
|
| --- a/base/test/trace_event_analyzer.cc
|
| +++ b/base/test/trace_event_analyzer.cc
|
| @@ -26,11 +26,27 @@ TraceEvent::TraceEvent()
|
| other_event(NULL) {
|
| }
|
|
|
| -TraceEvent::TraceEvent(const TraceEvent& other) = default;
|
| +TraceEvent::TraceEvent(const TraceEvent& other) {
|
| + *this = other;
|
| +}
|
|
|
| TraceEvent::~TraceEvent() {
|
| }
|
|
|
| +void TraceEvent::operator=(const TraceEvent& rhs) {
|
| + thread = rhs.thread;
|
| + timestamp = rhs.timestamp;
|
| + phase = rhs.phase;
|
| + category = rhs.category;
|
| + name = rhs.name;
|
| + id = rhs.id;
|
| + arg_numbers = rhs.arg_numbers;
|
| + arg_strings = rhs.arg_strings;
|
| + for (auto it = rhs.arg_values.cbegin(); it != rhs.arg_values.cend(); ++it) {
|
| + arg_values[it->first] = it->second->CreateDeepCopy();
|
| + }
|
| +}
|
| +
|
| bool TraceEvent::SetFromJSON(const base::Value* event_value) {
|
| if (event_value->GetType() != base::Value::TYPE_DICTIONARY) {
|
| LOG(ERROR) << "Value must be TYPE_DICTIONARY";
|
| @@ -54,6 +70,12 @@ bool TraceEvent::SetFromJSON(const base::Value* event_value) {
|
| bool require_id = (phase == TRACE_EVENT_PHASE_ASYNC_BEGIN ||
|
| phase == TRACE_EVENT_PHASE_ASYNC_STEP_INTO ||
|
| phase == TRACE_EVENT_PHASE_ASYNC_STEP_PAST ||
|
| + phase == TRACE_EVENT_PHASE_MEMORY_DUMP ||
|
| + phase == TRACE_EVENT_PHASE_ENTER_CONTEXT ||
|
| + phase == TRACE_EVENT_PHASE_LEAVE_CONTEXT ||
|
| + phase == TRACE_EVENT_PHASE_CREATE_OBJECT ||
|
| + phase == TRACE_EVENT_PHASE_DELETE_OBJECT ||
|
| + phase == TRACE_EVENT_PHASE_SNAPSHOT_OBJECT ||
|
| phase == TRACE_EVENT_PHASE_ASYNC_END);
|
|
|
| if (require_origin && !dictionary->GetInteger("pid", &thread.process_id)) {
|
| @@ -83,6 +105,7 @@ bool TraceEvent::SetFromJSON(const base::Value* event_value) {
|
| LOG(ERROR) << "args is missing from TraceEvent JSON";
|
| return false;
|
| }
|
| +
|
| if (require_id && !dictionary->GetString("id", &id)) {
|
| LOG(ERROR) << "id is missing from ASYNC_BEGIN/ASYNC_END TraceEvent JSON";
|
| return false;
|
| @@ -103,11 +126,9 @@ bool TraceEvent::SetFromJSON(const base::Value* event_value) {
|
| arg_numbers[it.key()] = static_cast<double>(boolean ? 1 : 0);
|
| } else if (it.value().GetAsDouble(&double_num)) {
|
| arg_numbers[it.key()] = double_num;
|
| - } else {
|
| - LOG(WARNING) << "Value type of argument is not supported: " <<
|
| - static_cast<int>(it.value().GetType());
|
| - continue; // Skip non-supported arguments.
|
| }
|
| + // Record all arguments as values.
|
| + arg_values[it.key()] = it.value().CreateDeepCopy();
|
| }
|
|
|
| return true;
|
| @@ -137,6 +158,17 @@ bool TraceEvent::GetArgAsNumber(const std::string& name,
|
| return false;
|
| }
|
|
|
| +bool TraceEvent::GetArgAsValue(const std::string& name,
|
| + scoped_ptr<base::Value>* arg) const {
|
| + std::map<std::string, scoped_ptr<base::Value>>::const_iterator i =
|
| + arg_values.find(name);
|
| + if (i != arg_values.end()) {
|
| + *arg = i->second->CreateDeepCopy();
|
| + return true;
|
| + }
|
| + return false;
|
| +}
|
| +
|
| bool TraceEvent::HasStringArg(const std::string& name) const {
|
| return (arg_strings.find(name) != arg_strings.end());
|
| }
|
| @@ -145,6 +177,10 @@ bool TraceEvent::HasNumberArg(const std::string& name) const {
|
| return (arg_numbers.find(name) != arg_numbers.end());
|
| }
|
|
|
| +bool TraceEvent::HasArg(const std::string& name) const {
|
| + return (arg_values.find(name) != arg_values.end());
|
| +}
|
| +
|
| std::string TraceEvent::GetKnownArgAsString(const std::string& name) const {
|
| std::string arg_string;
|
| bool result = GetArgAsString(name, &arg_string);
|
| @@ -173,6 +209,14 @@ bool TraceEvent::GetKnownArgAsBool(const std::string& name) const {
|
| return (arg_double != 0.0);
|
| }
|
|
|
| +scoped_ptr<base::Value> TraceEvent::GetKnownArgAsValue(
|
| + const std::string& name) const {
|
| + scoped_ptr<base::Value> arg_value;
|
| + bool result = GetArgAsValue(name, &arg_value);
|
| + DCHECK(result);
|
| + return arg_value;
|
| +}
|
| +
|
| // QueryNode
|
|
|
| QueryNode::QueryNode(const Query& query) : query_(query) {
|
|
|