Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1447533005: GN: Make NaCl toolchains run on Windows host (Closed)

Created:
5 years, 1 month ago by Roland McGrath
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Make NaCl toolchains run on Windows host The toolchain executables have the ".exe" suffix on Windows. Plumb through the readelf, nm, and strip tools for NaCl toolchains. These were accidentally using default host tools, which happen to work on other host platforms, but don't exist on Windows. BUG=512869 R=dpranke@chromium.org Committed: https://crrev.com/34fa90d65772e8b432d5c37cd607ed6d6dcc5ca0 Cr-Commit-Position: refs/heads/master@{#359715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -14 lines) Patch
M build/config/nacl/rules.gni View 2 chunks +9 lines, -1 line 0 comments Download
M build/toolchain/nacl/BUILD.gn View 6 chunks +45 lines, -12 lines 0 comments Download
M build/toolchain/nacl_toolchain.gni View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Roland McGrath
5 years, 1 month ago (2015-11-13 23:31:30 UTC) #1
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-13 23:34:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447533005/1
5 years, 1 month ago (2015-11-13 23:38:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-14 01:17:26 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 01:18:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34fa90d65772e8b432d5c37cd607ed6d6dcc5ca0
Cr-Commit-Position: refs/heads/master@{#359715}

Powered by Google App Engine
This is Rietveld 408576698