Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1447513002: tools/gn: include exec_process.h in the source file. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tfarina, Dirk Pranke, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: include exec_process.h in the source file. exec_process.cc is the source file implementation of exec_process.h, but somehow we forgot to include its corresponding header file. This patch fixes that. It also add it to the unittest file where it was also missing. build_config.h was also included for the usage of OS_XXX macros. BUG=None R=mostynb@opera.com TBR=brettw@chromium.org Committed: https://crrev.com/dbddfb93fea971bb8b3fa75117975c53633ee694 Cr-Commit-Position: refs/heads/master@{#359752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/gn/exec_process.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/exec_process_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
tfarina
PTAL.
5 years, 1 month ago (2015-11-13 20:12:52 UTC) #1
Mostyn Bramley-Moore
Non-owner lgtm.
5 years, 1 month ago (2015-11-13 20:25:02 UTC) #2
tfarina
TBRing Brett for this.
5 years, 1 month ago (2015-11-14 18:59:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447513002/1
5 years, 1 month ago (2015-11-14 19:00:09 UTC) #8
brettw
lgtm
5 years, 1 month ago (2015-11-14 23:52:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-15 02:40:24 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 02:41:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbddfb93fea971bb8b3fa75117975c53633ee694
Cr-Commit-Position: refs/heads/master@{#359752}

Powered by Google App Engine
This is Rietveld 408576698