Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 1447443002: [turbofan] Ensure inlined constructor calls still throw. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ensure inlined constructor calls still throw. This makes sure that inlining a constructor call to a function which cannot be used as a constructor (e.g. strong mode function) still does throw correctly when the implicit receiver is created. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-inline-strong-as-construct BUG=v8:4544 LOG=n Committed: https://crrev.com/83e9ea1e494d7d9125c3427f1c6b55b82f07aa36 Cr-Commit-Position: refs/heads/master@{#31982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M src/compiler/js-inlining.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-inline-strong-as-construct.js View 1 chunk +21 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-13 13:52:41 UTC) #1
Benedikt Meurer
LGTM, thanks.
5 years, 1 month ago (2015-11-13 13:54:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447443002/1
5 years, 1 month ago (2015-11-13 13:57:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 14:05:41 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83e9ea1e494d7d9125c3427f1c6b55b82f07aa36
Cr-Commit-Position: refs/heads/master@{#31982}

Powered by Google App Engine
This is Rietveld 408576698