Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1447433003:
DevTools: report error when DevTools fail to parse SourceMap. (Closed)
|
Created:
5 years, 1 month ago by lushnikov Modified:
3 years, 11 months ago Reviewers:
sportslivedecals, andrzej, pfeldman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: report error when DevTools fail to parse SourceMap.
BUG=497094
R=pfeldman
Committed: https://crrev.com/e8caec06b110814997692ecfa1f22ae11a736cd6
Cr-Commit-Position: refs/heads/master@{#359774}
Patch Set 1 #
Messages
Total messages: 27 (7 generated)
ptal
lgtm
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447433003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447433003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447433003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447433003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e8caec06b110814997692ecfa1f22ae11a736cd6 Cr-Commit-Position: refs/heads/master@{#359774}
Message was sent while issue was closed.
Is this fixed now? On Friday, November 13, 2015 at 11:00:05 AM UTC-8, lush...@chromium.org wrote: > > Reviewers: pfeldman > CL: https://codereview.chromium.org/1447433003/ > > Message: > ptal > > Description: > DevTools: report error when DevTools fail to parse SourceMap. > > BUG=497094 > R=pfeldman > > Base URL: https://chromium.googlesource.com/chromium/src.git@master > > Affected files (+1, -0 lines): > M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > Index: third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > index > bbafb62a08e56495b04ef53da7cac96c4c66db6d..7d31463eb6267a66d7f981d2ba2b7b965c16424b > > 100644 > --- a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > +++ b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > @@ -122,6 +122,7 @@ WebInspector.SourceMap.load = function(sourceMapURL, > compiledURL, callback) > callback(new WebInspector.SourceMap(baseURL, payload)); > } catch(e) { > console.error(e.message); > + WebInspector.console.error("Failed to parse SourceMap: " + > sourceMapURL); > callback(null); > } > } > > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Is this fixed now? On Friday, November 13, 2015 at 11:00:05 AM UTC-8, lush...@chromium.org wrote: > > Reviewers: pfeldman > CL: https://codereview.chromium.org/1447433003/ > > Message: > ptal > > Description: > DevTools: report error when DevTools fail to parse SourceMap. > > BUG=497094 > R=pfeldman > > Base URL: https://chromium.googlesource.com/chromium/src.git@master > > Affected files (+1, -0 lines): > M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > Index: third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > index > bbafb62a08e56495b04ef53da7cac96c4c66db6d..7d31463eb6267a66d7f981d2ba2b7b965c16424b > > 100644 > --- a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > +++ b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > @@ -122,6 +122,7 @@ WebInspector.SourceMap.load = function(sourceMapURL, > compiledURL, callback) > callback(new WebInspector.SourceMap(baseURL, payload)); > } catch(e) { > console.error(e.message); > + WebInspector.console.error("Failed to parse SourceMap: " + > sourceMapURL); > callback(null); > } > } > > > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
On 2016/04/01 17:04:37, sportslivedecals_gmail.com wrote: > Is this fixed now? > > On Friday, November 13, 2015 at 11:00:05 AM UTC-8, mailto:lush...@chromium.org > wrote: > > > > Reviewers: pfeldman > > CL: https://codereview.chromium.org/1447433003/ > > > > Message: > > ptal > > > > Description: > > DevTools: report error when DevTools fail to parse SourceMap. > > > > BUG=497094 > > R=pfeldman > > > > Base URL: https://chromium.googlesource.com/chromium/src.git@master > > > > Affected files (+1, -0 lines): > > M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > > > > Index: third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > > b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > index > > > bbafb62a08e56495b04ef53da7cac96c4c66db6d..7d31463eb6267a66d7f981d2ba2b7b965c16424b > > > > > 100644 > > --- a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > +++ b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > @@ -122,6 +122,7 @@ WebInspector.SourceMap.load = function(sourceMapURL, > > compiledURL, callback) > > callback(new WebInspector.SourceMap(baseURL, payload)); > > } catch(e) { > > console.error(e.message); > > + WebInspector.console.error("Failed to parse SourceMap: " + > > sourceMapURL); > > callback(null); > > } > > } > > > > > > > > -- > You received this message because you are subscribed to the Google Groups "Blink > Reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:blink-reviews+unsubscribe@chromium.org. Yes, the error is reported.
Message was sent while issue was closed.
I still see the error, what can I do to fix it on my machine? On Fri, Apr 1, 2016 at 10:17 AM, <lushnikov@chromium.org> wrote: > On 2016/04/01 17:04:37, sportslivedecals_gmail.com wrote: > > Is this fixed now? > > > > On Friday, November 13, 2015 at 11:00:05 AM UTC-8, mailto: > lush...@chromium.org > > > wrote: > > > > > > Reviewers: pfeldman > > > CL: https://codereview.chromium.org/1447433003/ > > > > > > Message: > > > ptal > > > > > > Description: > > > DevTools: report error when DevTools fail to parse SourceMap. > > > > > > BUG=497094 > > > R=pfeldman > > > > > > Base URL: https://chromium.googlesource.com/chromium/src.git@master > > > > > > Affected files (+1, -0 lines): > > > M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > > > > > > > Index: third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > diff --git > a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > > > > b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > index > > > > > > > bbafb62a08e56495b04ef53da7cac96c4c66db6d..7d31463eb6267a66d7f981d2ba2b7b965c16424b > > > > > > > > 100644 > > > --- a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > +++ b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > @@ -122,6 +122,7 @@ WebInspector.SourceMap.load = > function(sourceMapURL, > > > compiledURL, callback) > > > callback(new WebInspector.SourceMap(baseURL, payload)); > > > } catch(e) { > > > console.error(e.message); > > > + WebInspector.console.error("Failed to parse SourceMap: " + > > > sourceMapURL); > > > callback(null); > > > } > > > } > > > > > > > > > > > > > -- > > You received this message because you are subscribed to the Google Groups > "Blink > > Reviews" group. > > To unsubscribe from this group and stop receiving emails from it, send an > email > > to mailto:blink-reviews+unsubscribe@chromium.org. > > Yes, the error is reported. > > https://codereview.chromium.org/1447433003/ > -- *Robert Olide* SportsLiveDecals.com | Facebook.com/SportsLiveDecals Office: (562)758-3466 | Cell: (562)646-6580 -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
I still see the error, what can I do to fix it on my machine? On Fri, Apr 1, 2016 at 10:17 AM, <lushnikov@chromium.org> wrote: > On 2016/04/01 17:04:37, sportslivedecals_gmail.com wrote: > > Is this fixed now? > > > > On Friday, November 13, 2015 at 11:00:05 AM UTC-8, mailto: > lush...@chromium.org > > > wrote: > > > > > > Reviewers: pfeldman > > > CL: https://codereview.chromium.org/1447433003/ > > > > > > Message: > > > ptal > > > > > > Description: > > > DevTools: report error when DevTools fail to parse SourceMap. > > > > > > BUG=497094 > > > R=pfeldman > > > > > > Base URL: https://chromium.googlesource.com/chromium/src.git@master > > > > > > Affected files (+1, -0 lines): > > > M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > > > > > > > Index: third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > diff --git > a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > > > > b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > index > > > > > > > bbafb62a08e56495b04ef53da7cac96c4c66db6d..7d31463eb6267a66d7f981d2ba2b7b965c16424b > > > > > > > > 100644 > > > --- a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > +++ b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js > > > @@ -122,6 +122,7 @@ WebInspector.SourceMap.load = > function(sourceMapURL, > > > compiledURL, callback) > > > callback(new WebInspector.SourceMap(baseURL, payload)); > > > } catch(e) { > > > console.error(e.message); > > > + WebInspector.console.error("Failed to parse SourceMap: " + > > > sourceMapURL); > > > callback(null); > > > } > > > } > > > > > > > > > > > > > -- > > You received this message because you are subscribed to the Google Groups > "Blink > > Reviews" group. > > To unsubscribe from this group and stop receiving emails from it, send an > email > > to mailto:blink-reviews+unsubscribe@chromium.org. > > Yes, the error is reported. > > https://codereview.chromium.org/1447433003/ > -- *Robert Olide* SportsLiveDecals.com | Facebook.com/SportsLiveDecals Office: (562)758-3466 | Cell: (562)646-6580 -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Please, file a bug on crbug.com/new with exact details on what's going on - that would be a better place for the discussion.
Message was sent while issue was closed.
Are there any plans to fix it? If so what would be an estimated date? On Friday, April 1, 2016 at 1:04:35 PM UTC-4, sportsli...@gmail.com wrote: > > Is this fixed now? > > On Friday, November 13, 2015 at 11:00:05 AM UTC-8, lush...@chromium.org > wrote: >> >> Reviewers: pfeldman >> CL: https://codereview.chromium.org/1447433003/ >> >> Message: >> ptal >> >> Description: >> DevTools: report error when DevTools fail to parse SourceMap. >> >> BUG=497094 >> R=pfeldman >> >> Base URL: https://chromium.googlesource.com/chromium/src.git@master >> >> Affected files (+1, -0 lines): >> M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> >> >> Index: third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> diff --git >> a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> index >> bbafb62a08e56495b04ef53da7cac96c4c66db6d..7d31463eb6267a66d7f981d2ba2b7b965c16424b >> >> 100644 >> --- a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> +++ b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> @@ -122,6 +122,7 @@ WebInspector.SourceMap.load = function(sourceMapURL, >> >> compiledURL, callback) >> callback(new WebInspector.SourceMap(baseURL, payload)); >> } catch(e) { >> console.error(e.message); >> + WebInspector.console.error("Failed to parse SourceMap: " + >> sourceMapURL); >> callback(null); >> } >> } >> >> >> -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Are there any plans to fix it? If so what would be an estimated date? On Friday, April 1, 2016 at 1:04:35 PM UTC-4, sportsli...@gmail.com wrote: > > Is this fixed now? > > On Friday, November 13, 2015 at 11:00:05 AM UTC-8, lush...@chromium.org > wrote: >> >> Reviewers: pfeldman >> CL: https://codereview.chromium.org/1447433003/ >> >> Message: >> ptal >> >> Description: >> DevTools: report error when DevTools fail to parse SourceMap. >> >> BUG=497094 >> R=pfeldman >> >> Base URL: https://chromium.googlesource.com/chromium/src.git@master >> >> Affected files (+1, -0 lines): >> M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> >> >> Index: third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> diff --git >> a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> index >> bbafb62a08e56495b04ef53da7cac96c4c66db6d..7d31463eb6267a66d7f981d2ba2b7b965c16424b >> >> 100644 >> --- a/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> +++ b/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js >> @@ -122,6 +122,7 @@ WebInspector.SourceMap.load = function(sourceMapURL, >> >> compiledURL, callback) >> callback(new WebInspector.SourceMap(baseURL, payload)); >> } catch(e) { >> console.error(e.message); >> + WebInspector.console.error("Failed to parse SourceMap: " + >> sourceMapURL); >> callback(null); >> } >> } >> >> >> -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
> That explains a lot. Have been subscribed to http://essaywriting.center for a while to resolve this issue. > Will fix it on my side as soon as possible to move further finally. > |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
