Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1447403003: SkTextBlob should store per-run text alignment (Closed)

Created:
5 years, 1 month ago by f(malita)
Modified:
5 years, 1 month ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkTextBlob should store per-run text alignment SkPaint::Align is only observed for kDefault_Positioning AFAICT, but part of the run logical font nevertheless. BUG=skia:4567 R=mtklein@google.com,halcanary@google.com Committed: https://skia.googlesource.com/skia/+/32d6b876163580711a07e96d9f29c9c1490a7271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M src/core/SkTextBlob.cpp View 4 chunks +5 lines, -0 lines 0 comments Download
M tests/TextBlobTest.cpp View 3 chunks +90 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
f(malita)
5 years, 1 month ago (2015-11-17 19:20:38 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447403003/1
5 years, 1 month ago (2015-11-17 19:20:55 UTC) #5
hal.canary
lgtm
5 years, 1 month ago (2015-11-17 19:25:22 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 19:29:53 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447403003/1
5 years, 1 month ago (2015-11-17 19:30:37 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 19:31:08 UTC) #12
mtklein
> SkPaint::Align is only observed for kDefault_Positioning AFAICT, but part of the run logical font ...
5 years, 1 month ago (2015-11-17 19:34:44 UTC) #13
mtklein
lgtm
5 years, 1 month ago (2015-11-17 19:35:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447403003/1
5 years, 1 month ago (2015-11-17 19:38:48 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 19:39:35 UTC) #17
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/32d6b876163580711a07e96d9f29c9c1490a7271

Powered by Google App Engine
This is Rietveld 408576698