Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 14474011: Reduce calls to SkMatrix::reset from GrDrawState (Closed)

Created:
7 years, 8 months ago by robertphillips
Modified:
7 years, 8 months ago
Reviewers:
jvanverth1, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Next in the continuing series of setup cost reduction CLs. This CL removes the 3.8% spent in SkMatrix::reset when running: "bench --match drawpointsdash_5_5_aa" Performance numbers will be forthcoming.

Patch Set 1 #

Patch Set 2 : Fixed bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -9 lines) Patch
M include/gpu/GrEffectStage.h View 1 12 chunks +54 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
lgtm
7 years, 8 months ago (2013-04-25 02:55:12 UTC) #1
robertphillips
This appears to be a win. Here are the results for the GPU benchs (old ...
7 years, 8 months ago (2013-04-25 13:51:05 UTC) #2
robertphillips
Here are the corresponding results for the shader-based rect drawing method: circles_fill GPU c 15.92 ...
7 years, 8 months ago (2013-04-25 15:00:22 UTC) #3
Tom Hudson
Any sense of why there's such a loss on e.g. circles_fill and circles_stroke?
7 years, 8 months ago (2013-04-25 15:31:20 UTC) #4
robertphillips
Despite running on a Mac with repeat count set to 200 we are still subject ...
7 years, 8 months ago (2013-04-25 17:15:48 UTC) #5
robertphillips
7 years, 8 months ago (2013-04-25 17:24:03 UTC) #6
Message was sent while issue was closed.
committed as r8861

Powered by Google App Engine
This is Rietveld 408576698