Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Issue 14474002: path ops : make it real (Closed)

Created:
7 years, 8 months ago by caryclark
Modified:
7 years, 8 months ago
Reviewers:
borenet, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

path ops : make it real Add an option to SkCanvas to turn on path ops when combining clips. Allow Op() to use one of the input paths as an output path. Fix a bug in Op() when the minuend is empty and the subtrahend is not (for difference). Change the build to allow core to depend on pathops. Committed: https://code.google.com/p/skia/source/detail?r=8855

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -14 lines) Patch
A gm/pathopsskpclip.cpp View 1 1 chunk +73 lines, -0 lines 0 comments Download
M gyp/core.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/core.gypi View 1 chunk +57 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M gyp/pathops_unittest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkCanvas.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 chunks +31 lines, -0 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caryclark
7 years, 8 months ago (2013-04-25 13:20:44 UTC) #1
reed1
lgtm
7 years, 8 months ago (2013-04-25 13:23:56 UTC) #2
caryclark
7 years, 8 months ago (2013-04-25 13:34:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r8855 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698