Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1447383002: Observatory: handle the case where package:foo imports are canonicalized as packages/foo. (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Observatory: handle the case where package:foo imports are canonicalized as packages/foo. BUG=http://dartbug.com/24925 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/f1391c7841f350bea81200c8f5a66790201b4af9

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M runtime/observatory/lib/src/elements/script_inset.dart View 1 chunk +12 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 1 month ago (2015-11-17 01:39:50 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1447383002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/1447383002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart#newcode675 runtime/observatory/lib/src/elements/script_inset.dart:675: if (targetUri.scheme == 'package') { I guess this ...
5 years, 1 month ago (2015-11-17 01:42:31 UTC) #3
rmacnak
https://codereview.chromium.org/1447383002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/1447383002/diff/1/runtime/observatory/lib/src/elements/script_inset.dart#newcode675 runtime/observatory/lib/src/elements/script_inset.dart:675: if (targetUri.scheme == 'package') { On 2015/11/17 01:42:31, floitsch ...
5 years, 1 month ago (2015-11-17 01:53:07 UTC) #4
rmacnak
5 years, 1 month ago (2015-11-17 01:55:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1391c7841f350bea81200c8f5a66790201b4af9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698