Issue 1447373002: re-land Use FunctionElementImpl for inline function type parameters

Issue 1447373002: re-land Use FunctionElementImpl for inline function type parameters (Closed)

Created:
5 years, 1 month ago by Jennifer Messerly

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

re-land Use FunctionElementImpl for inline function type parameters This reverts commit 2990a0933af711a0b7d964debeb222dd130477c2. And fixes the test failure. The one additional change is in error_verifier.dart Previous reviews: (initial) https://codereview.chromium.org/1435153007/ (revert) https://codereview.chromium.org/1445273002/ R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/09625df4a99960c779d452757978512894bccd5a

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -55 lines)			Patch
M	pkg/analyzer/lib/src/generated/element.dart	View	2 chunks	+9 lines, -18 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error_verifier.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1 chunk	+6 lines, -27 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	2 chunks	+31 lines, -10 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

Pretty simple fix. We were missing one case caused by the switch from a typedef ...

5 years, 1 month ago (2015-11-17 01:41:56 UTC) #3

Jennifer Messerly

5 years, 1 month ago (2015-11-17 22:13:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
09625df4a99960c779d452757978512894bccd5a (presubmit successful).