Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1447353002: Start isolates in a separate thread. (Closed)

Created:
5 years, 1 month ago by turnidge
Modified:
5 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -99 lines) Patch
M runtime/lib/isolate.cc View 5 chunks +72 lines, -57 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 2 chunks +24 lines, -23 lines 0 comments Download
M runtime/tests/vm/dart/spawn_shutdown_test.dart View 1 2 3 4 5 1 chunk +35 lines, -18 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 3 4 5 6 4 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 5 6 4 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/isolate_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
5 years, 1 month ago (2015-11-17 18:06:06 UTC) #3
siva
lgtm https://codereview.chromium.org/1447353002/diff/100001/runtime/tests/vm/dart/spawn_shutdown_test.dart File runtime/tests/vm/dart/spawn_shutdown_test.dart (right): https://codereview.chromium.org/1447353002/diff/100001/runtime/tests/vm/dart/spawn_shutdown_test.dart#newcode49 runtime/tests/vm/dart/spawn_shutdown_test.dart:49: } I have always wondered about this, we ...
5 years, 1 month ago (2015-11-18 00:15:05 UTC) #4
turnidge
5 years, 1 month ago (2015-11-18 19:02:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
71b3d5aba894daeaf04165f10f0fd302251d6b4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698