Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 144733003: Let svg event attributes be reflected the same as html event attributes. (Closed)

Created:
6 years, 11 months ago by Erik Dahlström (inactive)
Modified:
6 years, 10 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, ed+blinkwatch_opera.com, krit, dglazkov+blink, f(malita), adamk+blink_chromium.org, gyuyoung.kim_webkit.org, pdr, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Let svg event attributes be reflected the same as html event attributes. Corresponds to "SVGElement implements GlobalEventHandlers", https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement. BUG=338288 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166087

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -88 lines) Patch
M LayoutTests/fast/dom/event-attribute-availability-expected.txt View 1 chunk +80 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/global-event-handlers-expected.txt View 49 chunks +49 lines, -49 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/event-attribute-availability.js View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 2 chunks +9 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Erik Dahlström (inactive)
6 years, 11 months ago (2014-01-24 16:15:37 UTC) #1
Stephen Chennney
LGTM. Could you please create a bug for this, with a little more of the ...
6 years, 11 months ago (2014-01-24 16:26:57 UTC) #2
fs
On 2014/01/24 16:26:57, Stephen Chenney wrote: > LGTM. > > Could you please create a ...
6 years, 11 months ago (2014-01-24 16:41:26 UTC) #3
Stephen Chennney
On 2014/01/24 16:41:26, fs wrote: > On 2014/01/24 16:26:57, Stephen Chenney wrote: > > LGTM. ...
6 years, 11 months ago (2014-01-24 16:45:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/144733003/20001
6 years, 10 months ago (2014-01-30 00:07:19 UTC) #5
commit-bot: I haz the power
Change committed as 166087
6 years, 10 months ago (2014-01-30 06:18:07 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 06:21:00 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698