Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7446)

Unified Diff: chrome/common/extensions/permissions/usb_device_permission.cc

Issue 14473014: Fix USB Permission string (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/usb_device_permission.cc
diff --git a/chrome/common/extensions/permissions/usb_device_permission.cc b/chrome/common/extensions/permissions/usb_device_permission.cc
index 739617520820aebef1212086987bf53e4784ebcd..7de3e374e871e82668856018ff62bc36ad9972d0 100644
--- a/chrome/common/extensions/permissions/usb_device_permission.cc
+++ b/chrome/common/extensions/permissions/usb_device_permission.cc
@@ -37,32 +37,31 @@ PermissionMessages UsbDevicePermission::GetMessages() const {
// device.gyp:device_usb is not available when extensions are disabled.
for (std::set<UsbDevicePermissionData>::const_iterator i =
data_set_.begin(); i != data_set_.end(); ++i) {
-
const char* vendor = device::UsbIds::GetVendorName(i->vendor_id());
- string16 vendor_name;
- if (vendor) {
- vendor_name = ASCIIToUTF16(vendor);
- } else {
- vendor_name = l10n_util::GetStringUTF16(
- IDS_EXTENSION_PROMPT_WARNING_UNKNOWN_USB_VENDOR);
- }
- const char* product =
- device::UsbIds::GetProductName(i->vendor_id(), i->product_id());
- string16 product_name;
- if (product) {
- product_name = ASCIIToUTF16(product);
+ if (vendor) {
+ const char* product =
+ device::UsbIds::GetProductName(i->vendor_id(), i->product_id());
+ if (product) {
+ result.push_back(PermissionMessage(
+ PermissionMessage::kUsbDevice,
+ l10n_util::GetStringFUTF16(
+ IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE,
+ ASCIIToUTF16(product),
+ ASCIIToUTF16(vendor))));
+ } else {
+ result.push_back(PermissionMessage(
+ PermissionMessage::kUsbDevice,
+ l10n_util::GetStringFUTF16(
+ IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE_MISSING_PRODUCT,
+ ASCIIToUTF16(vendor))));
+ }
} else {
- product_name = l10n_util::GetStringUTF16(
- IDS_EXTENSION_PROMPT_WARNING_UNKNOWN_USB_PRODUCT);
- }
-
- result.push_back(PermissionMessage(
+ result.push_back(PermissionMessage(
PermissionMessage::kUsbDevice,
- l10n_util::GetStringFUTF16(
- IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE,
- product_name,
- vendor_name)));
+ l10n_util::GetStringUTF16(
+ IDS_EXTENSION_PROMPT_WARNING_USB_DEVICE_MISSING_VENDOR)));
+ }
}
#else
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698