Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14473002: The bison grammar for @supports should return 0 in case of an error. (Closed)

Created:
7 years, 8 months ago by Peter Beverloo
Modified:
7 years, 8 months ago
Reviewers:
tony, eseidel, inferno, ojan
CC:
blink-reviews, apavlov+blink_chromium.org, darktears, inferno
Visibility:
Public.

Description

The bison grammar for @supports should return 0 in case of an error. BUG=234635, 234537 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, --1 lines) Patch
A LayoutTests/css3/supports-crash.html View 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/css3/supports-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/css/CSSGrammar.y.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Peter Beverloo
Inferno: mind taking a look?
7 years, 8 months ago (2013-04-24 13:52:38 UTC) #1
inferno
don't know this code well enough. ccing folks.
7 years, 8 months ago (2013-04-24 14:37:06 UTC) #2
eseidel
lgtm
7 years, 8 months ago (2013-04-24 18:37:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/14473002/1
7 years, 8 months ago (2013-04-24 18:37:56 UTC) #4
commit-bot: I haz the power
Presubmit check for 14473002-1 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 8 months ago (2013-04-24 18:43:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/14473002/1
7 years, 8 months ago (2013-04-24 18:50:50 UTC) #6
commit-bot: I haz the power
Presubmit check for 14473002-1 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 8 months ago (2013-04-24 18:56:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/14473002/1
7 years, 8 months ago (2013-04-25 10:36:32 UTC) #8
commit-bot: I haz the power
Presubmit check for 14473002-1 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 8 months ago (2013-04-25 10:42:33 UTC) #9
Peter Beverloo
7 years, 8 months ago (2013-04-26 14:56:14 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 manually as r149202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698