Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1447283006: [Autofill] Clicking datalist chooser arrow now shows Autofill/Autocomplete (Closed)

Created:
5 years, 1 month ago by Mathieu
Modified:
5 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Clicking datalist chooser arrow now shows Autofill/Autocomplete Previous implementation had a flash where we would see datalist only, then the full list with Autofill (see bug for description). Behavior now is to show the full list of suggestions that we have (datalist + Autofill/autocomplete, if available). BUG=558530 TEST=manual Committed: https://crrev.com/5f90bce226b6d480466091cd2940768619b16fd3 Cr-Commit-Position: refs/heads/master@{#361044}

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 6 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Mathieu
Hi Evan, PTAL.
5 years, 1 month ago (2015-11-19 19:49:34 UTC) #2
Mathieu
Hi Evan, PTAL.
5 years, 1 month ago (2015-11-19 20:09:24 UTC) #4
Evan Stade
lgtm
5 years, 1 month ago (2015-11-20 21:28:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447283006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447283006/20001
5 years, 1 month ago (2015-11-20 22:15:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/138334)
5 years, 1 month ago (2015-11-20 23:21:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447283006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447283006/20001
5 years, 1 month ago (2015-11-22 13:30:53 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-22 20:17:11 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-22 20:30:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f90bce226b6d480466091cd2940768619b16fd3
Cr-Commit-Position: refs/heads/master@{#361044}

Powered by Google App Engine
This is Rietveld 408576698