Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 1447273003: Make the FloatSize constructor from an IntSize explicit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/ViewportTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
index 9d2e7f75a97bf1fe00631c36315fe442ede3feda..3e54d0fa694925fbc891fc0633a986c0d2fd1979 100644
--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
@@ -459,7 +459,7 @@ TEST_P(ParameterizedVisualViewportTest, TestVisibleRect)
visualViewport.setSize(size);
// Scale the viewport to 2X; size should not change.
- FloatRect expectedRect(FloatPoint(0, 0), size);
+ FloatRect expectedRect(FloatPoint(0, 0), FloatSize(size));
expectedRect.scale(0.5);
visualViewport.setScale(2);
EXPECT_EQ(2, visualViewport.scale());
@@ -477,7 +477,7 @@ TEST_P(ParameterizedVisualViewportTest, TestVisibleRect)
// Scale the viewport to 3X to introduce some non-int values.
FloatPoint oldLocation = expectedRect.location();
- expectedRect = FloatRect(FloatPoint(), size);
+ expectedRect = FloatRect(FloatPoint(), FloatSize(size));
expectedRect.scale(1 / 3.0f);
expectedRect.setLocation(oldLocation);
visualViewport.setScale(3);
« no previous file with comments | « third_party/WebKit/Source/web/tests/ViewportTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698