Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1847)

Unified Diff: mojo/services/log/interfaces/log.mojom

Issue 1447273002: Mojo Log service and a thread-safe client library. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: removed environment & bindings changes from previous patchset. remove unused mojo::log::EntryMetad… Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/log/interfaces/log.mojom
diff --git a/mojo/services/log/interfaces/log.mojom b/mojo/services/log/interfaces/log.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..2a6641b9744eb38a37735da7c974fce06033122a
--- /dev/null
+++ b/mojo/services/log/interfaces/log.mojom
@@ -0,0 +1,19 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module mojo.log;
+
+import "log/interfaces/entry.mojom";
+
+// A log interface provides a way to do log source-code-level message entries.
viettrungluu 2015/11/20 23:21:51 I'd just say: "An interface for logging, e.g., to
vardhan 2015/12/02 00:06:14 Done.
+// For example, this could be log messages generated from calling MOJO_LOG() in
+// C++.
+// TODO(vardhan): How do we "globally silence" log entries issued by many
viettrungluu 2015/11/20 23:21:51 What do you mean "silence"?
vardhan 2015/12/02 00:06:14 (discussed offline) This TODO is basically trying
+// consumers of this interface? Should |Log| provide controls for log levels?
viettrungluu 2015/11/20 23:21:51 The answer to your second question is "no". In par
vardhan 2015/12/02 00:06:13 (discussed offline; see above)
+// or should clients register a "LogClientController" with this interface, and
viettrungluu 2015/11/20 23:21:51 The answer to your third question is "maybe". But
vardhan 2015/12/02 00:06:13 (discussed offline; see above)
+// |Log| will control their log levels?
+[ServiceName="mojo::log::Log"]
+interface Log {
+ AddEntry(Entry entry);
+};

Powered by Google App Engine
This is Rietveld 408576698