Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Unified Diff: mojo/public/cpp/environment/lib/environment.cc

Issue 1447273002: Mojo Log service and a thread-safe client library. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fix destructor race condition in log_client.cc; add some comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/environment/environment.h ('k') | mojo/public/cpp/environment/lib/logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/environment/lib/environment.cc
diff --git a/mojo/public/cpp/environment/lib/environment.cc b/mojo/public/cpp/environment/lib/environment.cc
index 6fb7e22a2204ef57185897050d743391b5a1684a..b5214718323bcbf927aeb01301cf54accc5c53ed 100644
--- a/mojo/public/cpp/environment/lib/environment.cc
+++ b/mojo/public/cpp/environment/lib/environment.cc
@@ -23,6 +23,7 @@ void Init(const MojoAsyncWaiter* default_async_waiter,
g_default_async_waiter = default_async_waiter
? default_async_waiter
: &internal::kDefaultAsyncWaiter;
+
viettrungluu 2015/11/17 22:33:33 nit: Adding this blank line seems gratuitous.
g_default_logger =
default_logger ? default_logger : &internal::kDefaultLogger;
@@ -62,6 +63,13 @@ const MojoLogger* Environment::GetDefaultLogger() {
}
// static
+void Environment::SetDefaultLogger(const MojoLogger* logger) {
+ assert(g_default_logger); // Fails if not "inside" |Environment|.
+ assert(logger);
viettrungluu 2015/11/17 22:33:33 Maybe setting it to null should mean using &intern
vardhan 2015/12/02 00:06:13 sounds right (Done.)
+ g_default_logger = logger;
+}
+
+// static
void Environment::InstantiateDefaultRunLoop() {
assert(!RunLoop::current());
// Not leaked: accessible from |RunLoop::current()|.
« no previous file with comments | « mojo/public/cpp/environment/environment.h ('k') | mojo/public/cpp/environment/lib/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698