Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: mojo/public/cpp/bindings/lib/message_builder.h

Issue 1447273002: Mojo Log service and a thread-safe client library. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fix destructor race condition in log_client.cc; add some comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/message_builder.h
diff --git a/mojo/public/cpp/bindings/lib/message_builder.h b/mojo/public/cpp/bindings/lib/message_builder.h
index 86ae71db142431980d02dfef94759742dd1abaf4..535f8e47386a301c7c306f01f3bb54865ababb2b 100644
--- a/mojo/public/cpp/bindings/lib/message_builder.h
+++ b/mojo/public/cpp/bindings/lib/message_builder.h
@@ -14,14 +14,14 @@
namespace mojo {
class Message;
-namespace internal {
-
class MessageBuilder {
public:
MessageBuilder(uint32_t name, size_t payload_size);
~MessageBuilder();
- Buffer* buffer() { return &buf_; }
+ // TODO(vardhan): |buffer()| is internal and only consumed by internal classes
+ // and unittests. Consider making it private + friend class its consumers?
+ internal::Buffer* buffer() { return &buf_; }
Message* message() { return &message_; }
protected:
@@ -29,7 +29,7 @@ class MessageBuilder {
void Initialize(size_t size);
Message message_;
- FixedBuffer buf_;
+ internal::FixedBuffer buf_;
MOJO_DISALLOW_COPY_AND_ASSIGN(MessageBuilder);
};
@@ -47,7 +47,7 @@ class RequestMessageBuilder : public MessageWithRequestIDBuilder {
RequestMessageBuilder(uint32_t name, size_t payload_size)
: MessageWithRequestIDBuilder(name,
payload_size,
- kMessageExpectsResponse,
+ internal::kMessageExpectsResponse,
0) {}
};
@@ -58,11 +58,10 @@ class ResponseMessageBuilder : public MessageWithRequestIDBuilder {
uint64_t request_id)
: MessageWithRequestIDBuilder(name,
payload_size,
- kMessageIsResponse,
+ internal::kMessageIsResponse,
request_id) {}
};
-} // namespace internal
} // namespace mojo
#endif // MOJO_PUBLIC_CPP_BINDINGS_LIB_MESSAGE_BUILDER_H_

Powered by Google App Engine
This is Rietveld 408576698