Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: mojo/services/log/cpp/BUILD.gn

Issue 1447273002: Mojo Log service and a thread-safe client library. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: initialize global variables at start of the test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/BUILD.gn ('k') | mojo/services/log/cpp/lib/log_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/log/cpp/BUILD.gn
diff --git a/mojo/services/files/cpp/BUILD.gn b/mojo/services/log/cpp/BUILD.gn
similarity index 55%
copy from mojo/services/files/cpp/BUILD.gn
copy to mojo/services/log/cpp/BUILD.gn
index c14aaada056427d819a70b1b110470d4723a7a6e..f7f3fedf522de8197e9ce4ddf85280359d2d322b 100644
--- a/mojo/services/files/cpp/BUILD.gn
+++ b/mojo/services/log/cpp/BUILD.gn
@@ -6,21 +6,17 @@ import("//build/module_args/mojo.gni")
import("$mojo_sdk_root/mojo/public/mojo_application.gni")
import("$mojo_sdk_root/mojo/public/mojo_sdk.gni")
-# files_impl is a helper library for *implementing* various interfaces in
-# |mojo.files|.
-mojo_sdk_source_set("files_impl") {
- # TODO(vtl): This is needed because mojo_sdk.gni doesn't understand relative
- # dependencies (so without this we can't depend on our interfaces!). Should
- # this target even be a mojo_sdk_source_set?
+# log_client is a helper library for talking to the mojo log service (see
+# log.mojo).
+# TODO(vardhan): should this be an SDK source set?
+mojo_sdk_source_set("log_client") {
restrict_external_deps = false
public_configs = [ "../../public/build/config:mojo_services" ]
sources = [
- "input_stream_file.h",
- "lib/input_stream_file.cc",
- "lib/output_stream_file.cc",
- "output_stream_file.h",
+ "lib/log_client.cc",
+ "log_client.h",
]
deps = [
@@ -29,31 +25,28 @@ mojo_sdk_source_set("files_impl") {
mojo_sdk_deps = [
"mojo/public/cpp/bindings",
- "mojo/public/cpp/bindings:callback",
"mojo/public/cpp/environment",
"mojo/public/cpp/system",
]
}
-mojo_native_application("files_impl_apptests") {
- output_name = "files_impl_apptests"
+mojo_native_application("log_client_apptests") {
+ output_name = "log_client_apptests"
testonly = true
sources = [
- "tests/input_stream_file_unittest.cc",
- "tests/output_stream_file_unittest.cc",
+ "tests/log_client_unittest.cc",
]
deps = [
- ":files_impl",
- "../interfaces",
- "$mojo_sdk_root/mojo/public/cpp/application:standalone",
- "$mojo_sdk_root/mojo/public/cpp/application:test_support_standalone",
+ ":log_client",
"$mojo_sdk_root/mojo/public/cpp/bindings",
"$mojo_sdk_root/mojo/public/cpp/environment",
- "$mojo_sdk_root/mojo/public/cpp/system",
+ "$mojo_sdk_root/mojo/public/cpp/application:standalone",
+ "$mojo_sdk_root/mojo/public/cpp/application:test_support_standalone",
"$mojo_sdk_root/mojo/public/cpp/utility",
+ "$mojo_sdk_root/mojo/services/log/interfaces",
"//testing/gtest",
]
}
« no previous file with comments | « mojo/BUILD.gn ('k') | mojo/services/log/cpp/lib/log_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698