PRESUBMIT.py - Issue 1447273002: Mojo Log service and a thread-safe client library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1447273002: Mojo Log service and a thread-safe client library. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: make min log level consistent with fallback logger, fix thread-safety, address trung's other commen… Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index d2391d0cd22325f0ed34ee19e4397205818038bd..91c3c18a70837aef533eb425c74b6438bd2abc47 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -644,6 +644,7 @@ def _CheckSpamLogging(input_api, output_api):

r"^examples/.*$",

r"^mojo/edk/util/logging_internal\.cc$",

r"^mojo/nacl/sfi/nacl_bindings/mojo_syscall\.cc$",

+ r"^services/log/log_impl\.cc$",

r"^shell/application_manager/network_fetcher\.cc$",

r"^shell/tracer\.cc$",

r"^sandbox/linux/.*",

« no previous file with comments | « no previous file | mojo/BUILD.gn » ('j') | mojo/public/cpp/environment/environment.h » ('J')