Mojo Log service and a thread-safe client library.

mojo/services/log/cpp/BUILD.gn

Index: mojo/services/log/cpp/BUILD.gn
diff --git a/mojo/services/files/cpp/BUILD.gn b/mojo/services/log/cpp/BUILD.gn
similarity index 55%
copy from mojo/services/files/cpp/BUILD.gn
copy to mojo/services/log/cpp/BUILD.gn
index c14aaada056427d819a70b1b110470d4723a7a6e..f7f3fedf522de8197e9ce4ddf85280359d2d322b 100644
--- a/mojo/services/files/cpp/BUILD.gn
+++ b/mojo/services/log/cpp/BUILD.gn
@@ -6,21 +6,17 @@ import("//build/module_args/mojo.gni")
 import("$mojo_sdk_root/mojo/public/mojo_application.gni")
 import("$mojo_sdk_root/mojo/public/mojo_sdk.gni")
 
-# files_impl is a helper library for *implementing* various interfaces in
-# |mojo.files|.
-mojo_sdk_source_set("files_impl") {
-  # TODO(vtl): This is needed because mojo_sdk.gni doesn't understand relative
-  # dependencies (so without this we can't depend on our interfaces!). Should
-  # this target even be a mojo_sdk_source_set?
+# log_client is a helper library for talking to the mojo log service (see
+# log.mojo).
+# TODO(vardhan): should this be an SDK source set?
+mojo_sdk_source_set("log_client") {
   restrict_external_deps = false

[viettrungluu, 2015/12/15 18:33:08]

Do you actually need this, if you using $mojo_sdk_root instead of ..?

[vardhan, 2015/12/16 18:29:04]

I based this build file off of files_impl build file, and made some assumptions
based off of it: 

I assumed that this /may/ not be part of a the mojo SDK proper (but dont know if
i can use anything other than a mojo_sdk_source_set() target) since it's not
part of mojo/public?  is $mojo_sdk_root assumed to be defined outside of the
SDK?

is mojo/services going to be part of the SDK proper?
if not, what can i use instead of mojo_sdk_source_set?
if so, should i (in addition to addressing your comments) also move the relative
deps=[] into fully-qualified mojo_sdk_deps?

 
   public_configs = [ "../../public/build/config:mojo_services" ]

[viettrungluu, 2015/12/15 18:33:08]

Should you write this using $mojo_sdk_root instead?

[vardhan, 2015/12/16 18:29:04]

(see above)

 
   sources = [
-    "input_stream_file.h",
-    "lib/input_stream_file.cc",
-    "lib/output_stream_file.cc",
-    "output_stream_file.h",
+    "lib/log_client.cc",
+    "log_client.h",
   ]
 
   deps = [
@@ -29,31 +25,28 @@ mojo_sdk_source_set("files_impl") {
 
   mojo_sdk_deps = [
     "mojo/public/cpp/bindings",
-    "mojo/public/cpp/bindings:callback",
     "mojo/public/cpp/environment",
     "mojo/public/cpp/system",
   ]
 }
 
-mojo_native_application("files_impl_apptests") {
-  output_name = "files_impl_apptests"
+mojo_native_application("log_client_apptests") {
+  output_name = "log_client_apptests"
 
   testonly = true
 
   sources = [
-    "tests/input_stream_file_unittest.cc",
-    "tests/output_stream_file_unittest.cc",
+    "tests/log_client_unittest.cc",
   ]
 
   deps = [
-    ":files_impl",
-    "../interfaces",
-    "$mojo_sdk_root/mojo/public/cpp/application:standalone",
-    "$mojo_sdk_root/mojo/public/cpp/application:test_support_standalone",
+    ":log_client",
     "$mojo_sdk_root/mojo/public/cpp/bindings",
     "$mojo_sdk_root/mojo/public/cpp/environment",
-    "$mojo_sdk_root/mojo/public/cpp/system",
+    "$mojo_sdk_root/mojo/public/cpp/application:standalone",
+    "$mojo_sdk_root/mojo/public/cpp/application:test_support_standalone",
     "$mojo_sdk_root/mojo/public/cpp/utility",
+    "$mojo_sdk_root/mojo/services/log/interfaces",

[viettrungluu, 2015/12/15 18:33:08]

Admittedly, it's weird to use $mojo_sdk_root for something that's not even in
the SDK proper. Hmmm.

[vardhan, 2015/12/16 18:29:04]

yeah.. i'm a little confused if $mojo_sdk_root can be expected to be  defined
outside of the SDK proper (i.e, for use in build files under mojo/services)

     "//testing/gtest",
   ]
 }