Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: mojo/services/log/interfaces/log.mojom

Issue 1447273002: Mojo Log service and a thread-safe client library. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: removed environment & bindings changes from previous patchset. remove unused mojo::log::EntryMetad… Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 module mojo.log;
6
7 import "log/interfaces/entry.mojom";
8
9 // A log interface provides a way to do log source-code-level message entries.
viettrungluu 2015/11/20 23:21:51 I'd just say: "An interface for logging, e.g., to
vardhan 2015/12/02 00:06:14 Done.
10 // For example, this could be log messages generated from calling MOJO_LOG() in
11 // C++.
12 // TODO(vardhan): How do we "globally silence" log entries issued by many
viettrungluu 2015/11/20 23:21:51 What do you mean "silence"?
vardhan 2015/12/02 00:06:14 (discussed offline) This TODO is basically trying
13 // consumers of this interface? Should |Log| provide controls for log levels?
viettrungluu 2015/11/20 23:21:51 The answer to your second question is "no". In par
vardhan 2015/12/02 00:06:13 (discussed offline; see above)
14 // or should clients register a "LogClientController" with this interface, and
viettrungluu 2015/11/20 23:21:51 The answer to your third question is "maybe". But
vardhan 2015/12/02 00:06:13 (discussed offline; see above)
15 // |Log| will control their log levels?
16 [ServiceName="mojo::log::Log"]
17 interface Log {
18 AddEntry(Entry entry);
19 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698