Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: PRESUBMIT.py

Issue 1447273002: Mojo Log service and a thread-safe client library. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: initialize global variables at start of the test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 def _CheckSpamLogging(input_api, output_api): 637 def _CheckSpamLogging(input_api, output_api):
638 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS 638 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS
639 black_list = (_EXCLUDED_PATHS + 639 black_list = (_EXCLUDED_PATHS +
640 _TEST_CODE_EXCLUDED_PATHS + 640 _TEST_CODE_EXCLUDED_PATHS +
641 input_api.DEFAULT_BLACK_LIST + 641 input_api.DEFAULT_BLACK_LIST +
642 (r"^base/logging\.h$", 642 (r"^base/logging\.h$",
643 r"^base/logging\.cc$", 643 r"^base/logging\.cc$",
644 r"^examples/.*$", 644 r"^examples/.*$",
645 r"^mojo/edk/util/logging_internal\.cc$", 645 r"^mojo/edk/util/logging_internal\.cc$",
646 r"^mojo/nacl/sfi/nacl_bindings/mojo_syscall\.cc$", 646 r"^mojo/nacl/sfi/nacl_bindings/mojo_syscall\.cc$",
647 r"^services/log/log_impl\.cc$",
647 r"^shell/application_manager/network_fetcher\.cc$", 648 r"^shell/application_manager/network_fetcher\.cc$",
648 r"^shell/tracer\.cc$", 649 r"^shell/tracer\.cc$",
649 r"^sandbox/linux/.*", 650 r"^sandbox/linux/.*",
650 r"^tools/.*")) 651 r"^tools/.*"))
651 source_file_filter = lambda x: input_api.FilterSourceFile( 652 source_file_filter = lambda x: input_api.FilterSourceFile(
652 x, white_list=(file_inclusion_pattern,), black_list=black_list) 653 x, white_list=(file_inclusion_pattern,), black_list=black_list)
653 654
654 log_macro = input_api.re.compile(r"\bD?LOG\s*\(\s*INFO\s*\)") 655 log_macro = input_api.re.compile(r"\bD?LOG\s*\(\s*INFO\s*\)")
655 log_if_macro = input_api.re.compile(r"\bD?LOG_IF\s*\(\s*INFO\s*,") 656 log_if_macro = input_api.re.compile(r"\bD?LOG_IF\s*\(\s*INFO\s*,")
656 printf_macro = input_api.re.compile(r"\bprintf\(") 657 printf_macro = input_api.re.compile(r"\bprintf\(")
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
1147 'Mojo Linux ASan Try', 1148 'Mojo Linux ASan Try',
1148 'Mojo Linux Try', 1149 'Mojo Linux Try',
1149 ] 1150 ]
1150 1151
1151 return GetDefaultTryConfigs(builders) 1152 return GetDefaultTryConfigs(builders)
1152 1153
1153 def PostUploadHook(cl, change, output_api): 1154 def PostUploadHook(cl, change, output_api):
1154 import subprocess 1155 import subprocess
1155 subprocess.check_call(["git", "cl", "try"]) 1156 subprocess.check_call(["git", "cl", "try"])
1156 return [] 1157 return []
OLDNEW
« no previous file with comments | « no previous file | mojo/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698