Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(758)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: mojo/services/log/interfaces/log.mojom
Issue
1447273002
:
Mojo Log service and a thread-safe client library. (Closed)
Base URL: https://github.com/domokit/mojo.git@master
Patch Set: fix race condition in unittest (by adding a 10ms wait)
Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
PRESUBMIT.py
mojo/BUILD.gn
mojo/services/log/cpp/BUILD.gn
mojo/services/log/cpp/lib/log_client.cc
mojo/services/log/cpp/log_client.h
mojo/services/log/cpp/tests/log_client_unittest.cc
mojo/services/log/interfaces/BUILD.gn
mojo/services/log/interfaces/entry.mojom
mojo/services/log/interfaces/log.mojom
mojo/services/mojo_services.gni
mojo/tools/data/apptests
services/BUILD.gn
services/log/BUILD.gn
services/log/log_impl.h
services/log/log_impl.cc
services/log/log_impl_unittest.cc
services/log/main.cc
View unified diff
|
Download patch
« mojo/services/log/cpp/lib/log_client.cc
('K') |
« mojo/services/log/interfaces/entry.mojom
('k') |
mojo/services/mojo_services.gni »
('j') |
services/log/log_impl_unittest.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2015 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
module mojo.log;
6
7
import "log/interfaces/entry.mojom";
8
9
// An interface for logging. e.g., to the system log service.
10
[ServiceName="mojo::log::Log"]
11
interface Log {
12
AddEntry(Entry entry);
13
};
OLD
NEW
« mojo/services/log/cpp/lib/log_client.cc
('K') |
« mojo/services/log/interfaces/entry.mojom
('k') |
mojo/services/mojo_services.gni »
('j') |
services/log/log_impl_unittest.cc »
('J')
Issue 1447273002: Mojo Log service and a thread-safe client library. (Closed)
Created 5 years, 1 month ago by vardhan
Modified 5 years ago
Reviewers: jamesr, viettrungluu
Base URL: https://github.com/domokit/mojo.git@master
Comments: 106
This is Rietveld
408576698
Chromium Code Reviews
Issue 1447273002:
Mojo Log service and a thread-safe client library. (Closed)
Base URL: https://github.com/domokit/mojo.git@master